Deploy Checklist: New Expensify 2021-11-15

[OSBotify]

Release Version: 1.1.15-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• [No QA] Only load full policies one-by-one as needed #6087

  • QA
  • Accessibility

• Add detail about including Upwork link for invite to Slack #6094

  • QA
  • Accessibility

• Remove lingering border from AddressSearch component #6115

  • QA
  • Accessibility

• Remove autofocus from the Edit messages and focus on the manual action #6138

  • QA
  • Accessibility

• Update eslint-config-expensify #6174

  • QA
  • Accessibility

• Deep link to add secondary login in OldDot #6176

  • QA
  • Accessibility

• Only set locale language from preferences #6177

  • QA
  • Accessibility

• Retry requests if storage (auth + credentials) is not ready #6183

  • QA
  • Accessibility

• Fix Promo colors on login screen for native devices #6185

  • QA
  • Accessibility

• Fix footer position on the login page in mobile View #6203

  • QA
  • Accessibility

• Make resizeMode dynamic #6206

  • QA
  • Accessibility

• Allow users to enter addresses manually when needed #6210

  • QA
  • Accessibility

• Upgrade Onfido sdk version to 6.15.2 #6211

  • QA
  • Accessibility

• [No QA] Add BankAccounts test #6217

  • QA
  • Accessibility

• [No QA] No Props/State Destructuring #6234

  • QA
  • Accessibility

• Update Web-Expensify references from master to main #6236

  • QA
  • Accessibility

• padding using wrapperStyle #6237

  • QA
  • Accessibility

• [CP Staging] Fix blank page upon signing out #6240

  • QA
  • Accessibility

• Update CONTRIBUTING.md #6241

  • QA
  • Accessibility

• Removing draft comments param #6252

  • QA
  • Accessibility

• [No QA] Only post to slack when job was successful #6256

  • QA
  • Accessibility

• Reset instead of deleting achData #6257

  • QA
  • Accessibility

• Fix language selector #6267

  • QA
  • Accessibility

• Include defaultRendererProps in InlineCodeBlock component #6270

  • QA
  • Accessibility

• Followup "Fix language selector" #6274

  • QA
  • Accessibility

• Add API Functions for User-Created Policy Rooms #6281

  • QA
  • Accessibility

• Re-add autoFocus prop for ExpensiText components #6300

  • QA
  • Accessibility

• Revert "Deep link to add secondary login in OldDot" #6313

  • QA
  • Accessibility

• Fix blank screen displayed on Company Step VBA flow #6327

  • QA
  • Accessibility

• Fix switching to manual address when adding bank account #6332

  • QA
  • Accessibility

• Pass translateX prop to TextInput component #6341

  • QA
  • Accessibility

• Add /partners/plaid/oauth_ios to apple-app-site-association #6366

  • QA
  • Accessibility

Internal QA:

• Start generating internal QA checklist with assignments #6102 - @yuwenmemon

Deploy Blockers:

• Login - Email and password fields are misaligned with left edge #6321
• Blank screen displayed after select Plaid Saving account for VBA flow #6322
• [Chat] Desktop - VBA- Can't find your address? link non functional in personal info page #6323
• VBA - Dropdown arrow non functional in zip code field for company info page #6324
• mWeb - 1.1.15-1 - Login - Continue button not visible when keyboard is opened #6325

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[mvtglobally]

Regression is completed
Deploy Blockers

• Login - Email and password fields are misaligned with left edge #6321
• Blank screen displayed after select Plaid Saving account for VBA flow #6322
• [Chat] Desktop - VBA- Can't find your address? link non functional in personal info page #6323
• VBA - Dropdown arrow non functional in zip code field for company info page #6324

Additional issues found

• mWeb - 1.1.15-1 - Login - Continue button not visible when keyboard is opened #6325
• Chat - Magnifying glass displayed anywhere on the modal page for small images #6326

Comments added
#4214 (comment)
#4717 (comment)

[isagoico]

We're testing these 2 CPs at the moment:

• Fix blank screen displayed on Company Step VBA flow #6327
• Fix switching to manual address when adding bank account #6332

[isagoico]

Both CPs were a pass 🎉 Checked them off already

Also checked off #6325 since the DB label was removed.

[yuwenmemon]

Checking off internal QA checklist (It worked cause it's there and tagged me correctly 😅 )

[isagoico]

@roryabraham I don't see #6341 was added to the Checklist, should we QA it?

[Jag96]

Hmm, that might be a bug since it was manually cherry-picked. Yes, let's QA #6341 since it fixes #6321

[isagoico]

@Jag96 Looks like something is wrong with the Android build. It has been a while and we don't see 1.1.15-8 build to test #6341 😟

[Jag96]

@isagoico I just checked and it looks like the Android build is still in review, hopefully it will be available soon. I'll check tomorrow morning and if it's still in review I'll reach out to confirm there isn't anything wrong w/ the build.

[isagoico]

On another note, the retest was a pass in Web, Desktop and iOS. We'll be on standby for the Android build.

[isagoico]

Morning! I checked Android build and it's still showing build 1.1.15-1 in playstore 😟 Will check again after some time has passed.

[Jag96]

Just checked, looks like it's still waiting on Google to review. There isn't much we can do here so hopefully it finishes soon!

[roryabraham]

Shared the Android APK for 1.1.15-8 in slack.

[mvtglobally]

Its a Pass! Checking off

[roryabraham]

What's the story with #6115 ? Did we miss that one in QA?

[roryabraham]

Also @ogumen what's the current status of in-sprint Accessibility testing?

[isagoico]

What's the story with #6115 ? Did we miss that one in QA?

My bad, it was a pass. Just checked it off, I keep missing checkboxes in this new format 🤦

[ogumen]

Hi @roryabraham, actively working on it today

[isagoico]

Testing #6366 at the moment

[isagoico]

It was a pass for us and @TomatoToaster 🎉

[chiragsalian]

[AndrewGable]

This failed to deploy, reopening and will re-deploy once it's fixed

[AndrewGable]