Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language selector #6267

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix language selector #6267

merged 1 commit into from
Nov 9, 2021

Conversation

MonilBhavsar
Copy link
Contributor

@MonilBhavsar MonilBhavsar commented Nov 9, 2021

cc @roryabraham

Details

Pass proper arguments

Fixed Issues

Unable to load Language picker page in preferences on main
#6234 (comment)

Tests / QA Steps

  1. Go to Settings > Preferences and make sure it loads correctly
  2. Change language settings and make sure it works

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-11-09 at 12 49 43 PM

Mobile Web

Desktop

iOS

Android

@MonilBhavsar MonilBhavsar self-assigned this Nov 9, 2021
@MonilBhavsar MonilBhavsar requested a review from a team as a code owner November 9, 2021 07:14
@MelvinBot MelvinBot removed the request for review from a team November 9, 2021 07:14
Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and LGTM!

@MariaHCD MariaHCD merged commit e230e7e into main Nov 9, 2021
@MariaHCD MariaHCD deleted the monil-fixLanguagePicker branch November 9, 2021 10:21
@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@marcaaron
Copy link
Contributor

We are using withLocalize() for this component? So should this be

props.translate('preferencesPage.language');

instead of importing translate()?

@MonilBhavsar
Copy link
Contributor Author

Yes we can use it!

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @MariaHCD in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@ogumen
Copy link

ogumen commented Nov 21, 2021

The accessibility issue found in this PR:

  1. The language selector is announced without any label - failure of WCAG SC 4.1.2, similar to [high] JAWS+Chrome: Profile: Dropdown "Preferred Pronouns" does not announce its label #5649
    https://user-images.githubusercontent.com/88733897/142783997-af4fbd25-67c7-4a30-a1e3-6b0fcf08d1d6.mp4

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants