-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Promo colors on login screen for native devices #6185
Conversation
Gentle Bump @roryabraham This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor thing...
@@ -0,0 +1,17 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well (at least, fixes the linked issue) 👍
Yeah, Good suggestion. I am working on another PR related to login page. I can try to add that there if not much efforts. |
Nice, that extension |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
Details
Fixed Issues
$ #6070
Tests | QA Steps
Tested On
Screenshots
Web | Desktop
Mobile Web
iPAD
Android Tablet