Pass translateX prop to TextInput component #6341
Conversation
|
|
|
We're going to use this PR to test #6199 |
(cherry picked from commit bde9be1)
(cherry picked from commit bde9be1)
|
🚀 Cherry-picked to staging by @Jag96 in version: 1.1.15-8 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
| @@ -198,6 +198,7 @@ class BaseExpensiTextInput extends Component { | |||
| onBlur={this.onBlur} | |||
| onChangeText={this.setValue} | |||
| onPressOut={this.props.onPress} | |||
| translateX={this.props.translateX} | |||
There was a problem hiding this comment.
@Jag96 Just want to know where did you get to know about this prop? It's not in docs...
There was a problem hiding this comment.
I think it's a deprecated view prop: https://reactnative.dev/docs/transforms#decomposedmatrix-rotation-scalex-scaley-transformmatrix-translatex-translatey
There was a problem hiding this comment.
I only knew about it because we've used it in other parts of the app, I wasn't aware it was deprecated
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
|
🚀 Deployed to staging by @roryabraham in version: 1.1.15-18 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
cc @roryabraham
Details
This PR updates the ExpensiTextInput component to pass translateX to the child TextInput component, fixing an issue on Android where all inputs had extra space. Adding CP Staging label to fix deploy blocker.
Fixed Issues
$ #6321
Tests/QA
Tested On
Screenshots