Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - Full width of the payment option is not responsive #6232

Closed
kavimuru opened this issue Nov 5, 2021 · 4 comments
Closed

Payments - Full width of the payment option is not responsive #6232

kavimuru opened this issue Nov 5, 2021 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Nov 5, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing the PR #6196

Action Performed:

  1. Launch the app and login
  2. Go to Settings -> Payments
  3. Click on Add Payment method
  4. In Web / Desktop, verify the payment options width

Expected Result:

Full width of padding should be responsive

Actual Result:

Full width of padding is not responsive

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.1.14-0

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5313049_Recording__1100.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub
Issue was found when executing the PR #6196

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Nov 5, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Nice PR responsible is already linked to the issue which is under regression period.

@francoisl francoisl added the Reviewing Has a PR in review label Nov 8, 2021
@isagoico
Copy link

isagoico commented Nov 8, 2021

Retest for this was a pass! Closing

Recording.16.mp4

@isagoico isagoico closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants