Deploy Checklist: New Expensify 2021-11-04

[OSBotify]

Release Version: 1.1.14-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Clean up policy actions #6080

  • QA
  • Accessibility

• Ensures mini actions menu will disappear when attachment modal opens up #6083

  • QA
  • Accessibility

• LHN: Hide the pencil icon when message is sent or draft is deleted and show the icon when user started to type #6050 #6084

  • QA
  • Accessibility

• Added tooltip for the communications link #6140

  • QA
  • Accessibility

• Add login validation route back in NewDot #6149

  • QA
  • Accessibility

• Remove the step counter from "Let's finish in chat" step of VBA flow #6172

  • QA
  • Accessibility

• Corrected infinite loading problem if non-image file uploaded for profile image #6189

  • QA
  • Accessibility

• Added Spanish translation for example check image and Company types #6190

  • QA
  • Accessibility

• Fix an apostrophe to trigger a CP Build #6191

  • QA
  • Accessibility

• Improvement Payment options Padding #6196

  • QA
  • Accessibility

• Modifies code wrapper style iOS #6197

  • QA
  • Accessibility

• Update popover menu check to use isEmpty #6201

  • QA
  • Accessibility

• close Keyboard when opening drawer #6205

  • QA
  • Accessibility

• [CP Staging] Fix blank page upon signing out #6240

  • QA
  • Accessibility

• Removing draft comments param #6252

  • QA
  • Accessibility

Deploy Blockers:

• Chat - App freezes when login with second account after logout from an account #6228
• LHN - Changing priority to #focus mode doesn't reflect the changes in LHN #6231
• Payments - Full width of the payment option is not responsive #6232
• Blank screen after logout #6239
• Android - VBA - App crashed when initiating VBA flow 2nd time after disconnecting already added one #6246
• IOU - Label does not animate up and placeholder is not shown on text input - Reported by: @rushatgabhane  #6298

cc @Expensify/applauseleads

[mvtglobally]

Starting QA

[roryabraham]

The fix for #6239 is being CP'd in 1.1.14-1 here. (h\t @mountiny) @mvtglobally @isagoico Please retest once it's deployed, and if it passes, check off both the PR and deploy blocker from the checklist. Thanks!

[mountiny]

Also the #6228 should be fixed by the CP'd PR so it can be retested as well once deployed 🙇 @mvtglobally @isagoico

[roryabraham]

1.1.14-1 is finished deploying 🚀

[isagoico]

Both issues are being retested at the moment

Issues found on regression so far:

• Payments - Full width of the payment option is not responsive #6232 is failing Improvement Payment options Padding #6196
• LHN - Changing priority to #focus mode doesn't reflect the changes in LHN #6231
• Chat - Unable to mark as unread conversations with a single message initiated for the first time #6233
• Android - VBA - App crashed when initiating VBA flow 2nd time after disconnecting already added one #6246
• IOU - "Pay with Expensifycard" option is displayed for the deactivated Expensify card  #6247

We have a few steps left to finish, we will post here when done.

[isagoico]

Retests for #6228 and #6239 is finished and a pass! Checked them off the list.

Also, regression is finished! Issues found are listed here

[isagoico]

#6252 Retest was a pass!

[francoisl]

Hi @isagoico, we cherry-picked a fix for the blocker #6232 with v1.1.14-3, can you test again please?

Edit: also - double-checking, we can check #6246 off the list of blockers, correct?

[isagoico]

Edit: also - double-checking, we can check #6246 off the list of blockers, correct?

CC @NikkiWines about #6246
I see a PR was merged but not CPd to staging yet, should we still treat this as a deploy blocker?

[NikkiWines]

Oh, sorry - yes. I should've added that to the title, it's good to be CP'd

[francoisl]

Oh yeah my b, didn't notice it was not CP'ed yet. I just cherry-picked it, so you're welcome to test again now.

[isagoico]

#6196 and #6232 were a pass in Web and Desktop, checking them off.

[isagoico]

@francoisl Retest on Android was a pass 🎉 Still waiting on iOS build, 1.1.14-4 currently not available in TF.

[isagoico]

#6246 retest was a pass on Android and iOS! Checking it off

[Jag96]

#6298 has been fixed by #6300 so I think we can check it off.

It looks like #6233 (from this comment) is on a merge freeze, will ask for an update on that one.

Update: Looks like it isn't a deploy blocker though since it exists on production, so I think we're actually good to deploy here.

[Jag96]

[ogumen]

Added comments to all PRs where accessibility issues were found. The non-applicable PRs are: #6240 and #6252. The #6197 was blocked due to not having access to the iOS build.