Clean up policy actions #6080
Merged
Clean up policy actions #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
previously requested changes
Nov 1, 2021
deetergp
reviewed
Nov 3, 2021
| @@ -27,7 +27,7 @@ import { | |||
| } from '../../../components/Icon/Expensicons'; | |||
| import Permissions from '../../../libs/Permissions'; | |||
| import ONYXKEYS from '../../../ONYXKEYS'; | |||
| import {create, isAdminOfFreePolicy} from '../../../libs/actions/Policy'; | |||
| import * as Policy from '../../../libs/actions/Policy'; | |||
There was a problem hiding this comment.
NAB: Why * and not just replace create with createAndNavigate?
There was a problem hiding this comment.
More context here: #5984 (comment)
Basically we are going to change these all eventually so I got to this one now.
deetergp
approved these changes
Nov 3, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
36 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.1.13-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @roryabraham Longer term we probably want to solve the issue of why we can't get policies and create them at the same time, but this feels like a logical refactor. I think by splitting these out into their own methods things feel more intentional - even if the behavior is exactly the same for now.
Details
Clean up Policy actions
Fixed Issues
$ #6153
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android