Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login validation route back in NewDot #6149

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Add login validation route back in NewDot #6149

merged 4 commits into from
Nov 3, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Nov 1, 2021 •
edited
Loading

cc @NikkiWines

Details

Adds a login validation route that was removed in this PR, but should not have been.

Fixed Issues

$ #6136

Tests

  1. Log in to a validated account without any secondary logins in NewDot
  2. Navigate to Settings > Profile and add a secondary login for an account that you have access to
  3. Confirm the sent link routes you to NewDot not OldDot
  4. Click on the link and confirm your secondary login is validated
  5. Repeat steps 1 and 2
  6. Click on Resend to resend the validation link to yourself
  7. Repeat steps 3 and 4

QA Steps

  1. Complete Test steps while logged into an account on NewDot.
    • For step 5 ensure you are logged into the account when you click on the link
  2. Complete Test steps while logged into an account on NewDot.
    • For step 5 ensure you are logged out of the account when you click on the link

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@roryabraham roryabraham self-assigned this Nov 1, 2021
@roryabraham
Copy link
Contributor Author

Tested this on iOS on a physical device and it worked 🎉

@roryabraham roryabraham marked this pull request as ready for review November 1, 2021 18:55
@roryabraham roryabraham requested a review from a team as a code owner November 1, 2021 18:55
@MelvinBot MelvinBot requested review from deetergp and removed request for a team November 1, 2021 18:56
NikkiWines
NikkiWines reviewed Nov 1, 2021
View reviewed changes
src/pages/ValidateLoginPage.js
componentDidMount() {
const accountID = lodashGet(this.props.route.params, 'accountID', '');
const validateCode = lodashGet(this.props.route.params, 'validateCode', '');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: extra line

NikkiWines
NikkiWines previously approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested and works well

deetergp
deetergp previously approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but you've got a merge conflict 😬

@roryabraham
Merge branch 'main' into Rory-AddValidationLinkRouteBack
0696516 
# Conflicts:
#	src/pages/SetPasswordPage.js
@roryabraham roryabraham dismissed stale reviews from deetergp and NikkiWines via 0696516 November 3, 2021 18:42
@roryabraham
Copy link
Contributor Author

Updated!

NikkiWines
NikkiWines approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roryabraham roryabraham merged commit 0841cc4 into main Nov 3, 2021
@roryabraham roryabraham deleted the Rory-AddValidationLinkRouteBack branch November 3, 2021 21:03
@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 4, 2021
Closed
36 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2021

🚀 Deployed to staging by @roryabraham in version: 1.1.13-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@deetergp deetergp Awaiting requested review from deetergp

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @OSBotify @deetergp @NikkiWines