Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the step counter from "Let's finish in chat" step of VBA flow #6172

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 2, 2021

Details

Removed step counter and changed copy in Validation step.

Fixed Issues

$ #6123

Tests

  1. Login to an account in NewDot and create a Workspace.
  2. Navigate to Settings > Select Workspace > Connect bank account
  3. Follow the steps in this SO to add a Pending bank account, but in the company step enter 111222333 as the tax ID.
  4. Go through the flow until you reach the validation step.
  5. Verify that you do not see the step counter and the copy reads as follows:

Thanks for doing that! We need your help verifying a few pieces of information, but we can work this out quickly over chat. Ready?

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mweb

Desktop

desktop

iOS

ios

Android

android

@luacmartins luacmartins self-assigned this Nov 2, 2021
@luacmartins luacmartins marked this pull request as ready for review November 2, 2021 17:27
@luacmartins luacmartins requested a review from a team as a code owner November 2, 2021 17:27
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team November 2, 2021 17:27
@joelbettner
Copy link
Contributor

LGTM 👍

@joelbettner joelbettner merged commit 2281700 into main Nov 3, 2021
@joelbettner joelbettner deleted the cmartins-removeStepCounter branch November 3, 2021 21:18
@OSBotify
Copy link
Contributor

OSBotify commented Nov 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Nov 4, 2021

🚀 Deployed to staging by @joelbettner in version: 1.1.13-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants