Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new UpdatePolicyRoomName api command #10237

Merged
merged 36 commits into from
Aug 15, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
162ef4e
Create updatePolicyRoomName for api refactor
neil-marcellini Aug 3, 2022
0e38b5a
Use reportName param for WAF
neil-marcellini Aug 8, 2022
303a0a3
Use new updatePolicyRoomName command
neil-marcellini Aug 8, 2022
f265e7e
Add offline feedback / errors for policy room name
neil-marcellini Aug 9, 2022
124f8f5
Merge branch 'main' into neil-UpdatePolicyRoomName
neil-marcellini Aug 9, 2022
15fbbf8
Use rbr pending action update constant
neil-marcellini Aug 9, 2022
e657bd8
Fix JSDoc param type
neil-marcellini Aug 9, 2022
2fd2a55
Pass policyRoomName to UpdatePolicyRoomName
neil-marcellini Aug 9, 2022
7bdd021
Merge branch 'main' into neil-UpdatePolicyRoomName
neil-marcellini Aug 11, 2022
1847e5a
Check report errors and errorFields also
neil-marcellini Aug 11, 2022
f4a7b45
Add brick road indicator to header view
neil-marcellini Aug 11, 2022
f952838
Create hasReportNameError
neil-marcellini Aug 11, 2022
a77f503
Use hasReportNameError in HeaderView
neil-marcellini Aug 11, 2022
b7ad9f8
Fix hasReportNameError
neil-marcellini Aug 11, 2022
5070cbd
Allow empty string brickRoadIndicator
neil-marcellini Aug 11, 2022
20fdbdb
Brick road indicator on report details settings
neil-marcellini Aug 11, 2022
b388315
Use empty string for empty brickRoadIndicator
neil-marcellini Aug 11, 2022
292c524
Allow the error message to use the full row
neil-marcellini Aug 11, 2022
b493390
Name the onClose callback for what it does
neil-marcellini Aug 11, 2022
837f5db
Remove redundant comments
neil-marcellini Aug 11, 2022
45fa867
Remove deprecated rename report
neil-marcellini Aug 11, 2022
2a0683e
Remove policy room renamed growl
neil-marcellini Aug 11, 2022
3693e27
Rename to match api command name
neil-marcellini Aug 11, 2022
1bfae69
Merge branch 'main' into neil-UpdatePolicyRoomName
neil-marcellini Aug 11, 2022
acb83ab
Simplify brickRoadIndicator comment
neil-marcellini Aug 12, 2022
d33ef6a
Rename error vars that are specific to the report
neil-marcellini Aug 12, 2022
e4cbb45
Add a key to menu items for brick road indicator
neil-marcellini Aug 12, 2022
2eea06a
Remove unused props
neil-marcellini Aug 12, 2022
2a3c71f
Make default brickRoadIndicator match prop type
neil-marcellini Aug 12, 2022
924afb9
Clear reportName errors optimistically
neil-marcellini Aug 12, 2022
e0497af
Set roomNameInputRef inline for simplicity
neil-marcellini Aug 12, 2022
04cd7b4
Fix resetting the room name input on native
neil-marcellini Aug 12, 2022
06dd5d8
Use minimum vertical space for RBR error text
neil-marcellini Aug 12, 2022
eddd6ce
Add accessed report fields to JSDoc
neil-marcellini Aug 15, 2022
106ad15
Use constants for report details menu items
neil-marcellini Aug 15, 2022
4c150ff
Use constant
neil-marcellini Aug 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions src/libs/actions/Report.js
Original file line number Diff line number Diff line change
Expand Up @@ -1466,6 +1466,52 @@ function renameReport(reportID, reportName) {
.finally(() => Onyx.set(ONYXKEYS.IS_LOADING_RENAME_POLICY_ROOM, false));
}

/**
* Update the policy room name.
*
* @param {Object} policyRoomReport
neil-marcellini marked this conversation as resolved.
Show resolved Hide resolved
* @param {*} reportName The updated reportName
neil-marcellini marked this conversation as resolved.
Show resolved Hide resolved
*/
function updatePolicyRoomName(policyRoomReport, reportName) {
const reportID = policyRoomReport.reportID;
const previousName = policyRoomReport.reportName;
const optimisticData = [
{
onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
reportName,
pendingFields: {
reportName: 'update',
neil-marcellini marked this conversation as resolved.
Show resolved Hide resolved
},
},
},
];
const successData = [
{

onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
pendingFields: {
reportName: null,
},
neil-marcellini marked this conversation as resolved.
Show resolved Hide resolved
},
},
];
const failureData = [
{

onyxMethod: CONST.ONYX.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
value: {
reportName: previousName,
},
},
];
API.write('UpdatePolicyRoomName', {reportID, reportName}, {optimisticData, successData, failureData});
}

/**
* @param {Number} reportID
* @param {Boolean} isComposerFullSize
Expand Down Expand Up @@ -1618,4 +1664,5 @@ export {
openReport,
openPaymentDetailsPage,
createOptimisticReport,
updatePolicyRoomName,
};
2 changes: 1 addition & 1 deletion src/pages/ReportSettingsPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class ReportSettingsPage extends Component {
Growl.success(this.props.translate('newRoomPage.policyRoomRenamed'));
return;
}
Report.renameReport(this.props.report.reportID, this.state.newRoomName);
Report.updatePolicyRoomName(this.props.report, this.state.newRoomName);
}

validate() {
Expand Down