Focus input field follow up magic link #11163

syedsaroshfarrukhdot · 2022-09-21T14:45:01Z

Details

This PR fixes the issue of not focusing New Passowrd input field on following magic link.

Fixed Issues

$ #10968

Tests

Click on magic link in the email recieved.
Copy the link and change it to localhost URL.
Verify the new password input field is focused.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Click on magic link in the email recieved.
Copy the link and change it to localhost URL.
Verify the new password input field is focused.

Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-09-21.at.7.37.31.PM.mov

Mobile Web - Chrome

WhatsApp.Video.2022-09-21.at.7.41.16.PM.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-09-21.at.19.43.18.mp4

Desktop

Screen.Recording.2022-09-22.at.2.48.47.AM.mov

iOS

Screen.Recording.2022-09-22.at.2.46.40.AM.mov

Android

Screen.Recording.2022-09-22.at.3.04.18.AM.mov

parasharrajat · 2022-09-21T14:57:04Z

These are mandatory.

syedsaroshfarrukhdot · 2022-09-21T20:08:38Z

These are mandatory.

@parasharrajat Wouldn't the magic link only open New Password page in web browsers ?

parasharrajat · 2022-09-21T21:13:26Z

Nope, it will soon be started to open in the Native app or Desktop. We can't assume that it will only open on MWeb. You can directly open the URL on Native (via deep link) and manually set it on the desktop.

syedsaroshfarrukhdot · 2022-09-21T22:09:34Z

Nope, it will soon be started to open in the Native app or Desktop. We can't assume that it will only open on MWeb. You can directly open the URL on Native (via deep link) and manually set it on the desktop.

Okay, Thanks for letting me know. I just uploaded IOS, Android and Web videos.

parasharrajat · 2022-09-21T22:49:53Z

Is it me only or the keyboard is not opening up on Android and Android web?

Julesssss · 2022-09-22T10:11:41Z

I should have mentioned this before, but I think it might even be preferable to have the keyboard not show on native mobile -- this prevents janky-looking animations that lag due to the page also opening and gives users the choice between pasting in the password, or typing.

Julesssss · 2022-09-22T10:17:04Z

Ignore me, ^ that does seem to be the case already. I think it's totally fine to focus the field but not show the soft keyboard.

parasharrajat

OK.Thanks, Juless. LGTM.

cc: @Julesssss

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2022-09-22T10:53:51Z

@Julesssss looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2022-09-22T10:58:38Z

Nope, all checks had passed 👢

OSBotify · 2022-09-22T10:59:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-09-22T19:17:16Z

🚀 Deployed to staging by @Julesssss in version: 1.2.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-09-23T22:47:40Z

🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

syedsaroshfarrukhdot added 2 commits September 21, 2022 19:08

New Password Input Field Focus Fix

b149dae

New Password Input Field Focus Fix

819702b

syedsaroshfarrukhdot requested a review from a team as a code owner September 21, 2022 14:45

melvin-bot bot requested review from Julesssss and parasharrajat and removed request for a team September 21, 2022 14:45

Julesssss approved these changes Sep 22, 2022

View reviewed changes

Julesssss assigned syedsaroshfarrukhdot Sep 22, 2022

parasharrajat approved these changes Sep 22, 2022

View reviewed changes

Julesssss merged commit f76f708 into Expensify:main Sep 22, 2022

melvin-bot bot added the Emergency label Sep 22, 2022

Julesssss removed the Emergency label Sep 22, 2022

OSBotify mentioned this pull request Sep 22, 2022

Deploy Checklist: New Expensify 2022-09-22 #11215

Closed

20 tasks

melvin-bot bot mentioned this pull request Sep 23, 2022

[HOLD for payment 2022-09-30] [$250] Web - Login - The input field does not focus after following the magic link #10968

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Focus input field follow up magic link #11163

Focus input field follow up magic link #11163

syedsaroshfarrukhdot commented Sep 21, 2022 •

edited

Loading

parasharrajat commented Sep 21, 2022

syedsaroshfarrukhdot commented Sep 21, 2022 •

edited

Loading

parasharrajat commented Sep 21, 2022 •

edited

Loading

syedsaroshfarrukhdot commented Sep 21, 2022

parasharrajat commented Sep 21, 2022 •

edited

Loading

Julesssss commented Sep 22, 2022

Julesssss commented Sep 22, 2022

parasharrajat left a comment

melvin-bot bot commented Sep 22, 2022

Julesssss commented Sep 22, 2022

OSBotify commented Sep 22, 2022

OSBotify commented Sep 22, 2022

OSBotify commented Sep 23, 2022

Focus input field follow up magic link #11163

Focus input field follow up magic link #11163

Conversation

syedsaroshfarrukhdot commented Sep 21, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

parasharrajat commented Sep 21, 2022

syedsaroshfarrukhdot commented Sep 21, 2022 • edited Loading

parasharrajat commented Sep 21, 2022 • edited Loading

syedsaroshfarrukhdot commented Sep 21, 2022

parasharrajat commented Sep 21, 2022 • edited Loading

Julesssss commented Sep 22, 2022

Julesssss commented Sep 22, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

melvin-bot bot commented Sep 22, 2022

Julesssss commented Sep 22, 2022

OSBotify commented Sep 22, 2022

OSBotify commented Sep 22, 2022

OSBotify commented Sep 23, 2022

syedsaroshfarrukhdot commented Sep 21, 2022 •

edited

Loading

syedsaroshfarrukhdot commented Sep 21, 2022 •

edited

Loading

parasharrajat commented Sep 21, 2022 •

edited

Loading

parasharrajat commented Sep 21, 2022 •

edited

Loading