-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Require report prop on ReportActionItemCreate and ReportWelcomeText #11344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes looks good, but I think we could also add the prop reportID
as required to ReportActionItemCreated
here
App/src/pages/home/report/ReportActionItemCreated.js
Lines 15 to 36 in 9587df5
const propTypes = { | |
/** The report currently being looked at */ | |
report: PropTypes.shape({ | |
/** The id of the report */ | |
reportID: PropTypes.number, | |
/** Avatars corresponding to a chat */ | |
icons: PropTypes.arrayOf(PropTypes.string), | |
/** Whether the user is not an admin of policyExpenseChat chat */ | |
isOwnPolicyExpenseChat: PropTypes.bool, | |
}).isRequired, | |
/** Personal details of all the users */ | |
personalDetails: PropTypes.objectOf(participantPropTypes), | |
/** The policies which the user has access to and which the report could be tied to */ | |
policies: PropTypes.shape({ | |
/** Name of the policy */ | |
name: PropTypes.string, | |
}), | |
}; |
since we are passing it here
App/src/pages/home/report/ReportActionItem.js
Line 133 in 9587df5
return <ReportActionItemCreated reportID={this.props.report.reportID} />; |
Oh yeah, thanks for catching that @aldo-expensify! |
Updated! |
@neil-marcellini looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Skipping the checklist https://github.com/Expensify/Expensify/issues/230010 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @neil-marcellini in version: 1.2.10-0 🚀
|
1 similar comment
🚀 Deployed to staging by @neil-marcellini in version: 1.2.10-0 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.2.10-1 🚀
|
…-proptypes [No QA] Require report prop on ReportActionItemCreate and ReportWelcomeText
Details
Coming from #10863 (comment), make the report prop required.
Fixed Issues
N/A
Tests
Sign in with any account
Click the green plus, New chat
Type in the name of a new user and click on their name
Verify that the new chat opens and has a welcome message like "This is the beginning of your chat history with "
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android