Empty State Design #13647
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import React from 'react'; | ||
| import {Pressable, ImageBackground, View} from 'react-native'; | ||
| import lodashGet from 'lodash/get'; | ||
| import {withOnyx} from 'react-native-onyx'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
@@ -12,6 +12,10 @@ import styles from '../../../styles/styles'; | |
| import OfflineWithFeedback from '../../../components/OfflineWithFeedback'; | ||
| import * as Report from '../../../libs/actions/Report'; | ||
| import reportPropTypes from '../../reportPropTypes'; | ||
| import EmptyStateBackgroundImage from '../../../../assets/images/empty-state_background-fade.png'; | ||
| import * as StyleUtils from '../../../styles/StyleUtils'; | ||
| import withWindowDimensions, {windowDimensionsPropTypes} from '../../../components/withWindowDimensions'; | ||
| import compose from '../../../libs/compose'; | ||
|
|
||
| const propTypes = { | ||
| /** The id of the report */ | ||
|
|
@@ -28,6 +32,8 @@ const propTypes = { | |
| /** Name of the policy */ | ||
| name: PropTypes.string, | ||
| }), | ||
|
|
||
| ...windowDimensionsPropTypes, | ||
| }; | ||
| const defaultProps = { | ||
| report: {}, | ||
|
|
@@ -37,28 +43,36 @@ const defaultProps = { | |
|
|
||
| const ReportActionItemCreated = (props) => { | ||
| const icons = ReportUtils.getIcons(props.report, props.personalDetails, props.policies); | ||
|
|
||
| return ( | ||
| <OfflineWithFeedback | ||
| pendingAction={lodashGet(props.report, 'pendingFields.addWorkspaceRoom') || lodashGet(props.report, 'pendingFields.createChat')} | ||
| errors={lodashGet(props.report, 'errorFields.addWorkspaceRoom') || lodashGet(props.report, 'errorFields.createChat')} | ||
| errorRowStyles={[styles.ml10, styles.mr2]} | ||
| onClose={() => Report.navigateToConciergeChatAndDeleteReport(props.report.reportID)} | ||
| > | ||
| <View style={StyleUtils.getReportWelcomeContainerStyle(props.isSmallScreenWidth)}> | ||
| <View pointerEvents="none" style={StyleUtils.getReportWelcomeBackgroundImageViewStyle(props.isSmallScreenWidth)}> | ||
| <ImageBackground | ||
| source={EmptyStateBackgroundImage} | ||
| style={StyleUtils.getReportWelcomeBackgroundImageStyle(props.isSmallScreenWidth)} | ||
| /> | ||
| </View> | ||
| <View | ||
| accessibilityLabel="Chat welcome message" | ||
|
There was a problem hiding this comment. Should we be using non-translated strings for There was a problem hiding this comment. There was a problem hiding this comment. let's translate this as well. There was a problem hiding this comment. See my comments in Slack - I agree that this should be changed BUT I think we need to handle that separately (for context, this was already here, I just moved it). It is being used for testing here and this is the pattern across the app. Again, I don't like this either but I think we can do another issue for this at this time. |
||
| style={styles.p5} | ||
| > | ||
| <Pressable | ||
| onPress={() => ReportUtils.navigateToDetailsPage(props.report)} | ||
| style={[styles.ph5, styles.pb3, styles.alignSelfStart]} | ||
| > | ||
| <RoomHeaderAvatars | ||
| icons={icons} | ||
| /> | ||
| </Pressable> | ||
| <View style={[styles.ph5]}> | ||
| <ReportWelcomeText report={props.report} /> | ||
| </View> | ||
| </View> | ||
| </View> | ||
| </OfflineWithFeedback> | ||
|
|
@@ -69,14 +83,17 @@ ReportActionItemCreated.defaultProps = defaultProps; | |
| ReportActionItemCreated.propTypes = propTypes; | ||
| ReportActionItemCreated.displayName = 'ReportActionItemCreated'; | ||
|
|
||
| export default compose( | ||
| withWindowDimensions, | ||
| withOnyx({ | ||
| report: { | ||
| key: ({reportID}) => `${ONYXKEYS.COLLECTION.REPORT}${reportID}`, | ||
| }, | ||
| personalDetails: { | ||
| key: ONYXKEYS.PERSONAL_DETAILS, | ||
| }, | ||
| policies: { | ||
| key: ONYXKEYS.COLLECTION.POLICY, | ||
| }, | ||
| }), | ||
| )(ReportActionItemCreated); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Removing that style shifts the text over to the left, to match the mocks. Not needed anymore.