Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append current time to the downloaded file name #23531

Merged

Conversation

bernhardoj
Copy link
Contributor

Details

We want to append the current time to every file downloaded on the App. This is to make every file downloaded has a unique name.

Fixed Issues

$ #23094
PROPOSAL: #23094 (comment)

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Requires internet connection to download

QA Steps

Only available on iOS/Android

  1. Create a chat room if you don't have one
  2. Open the chat room
  3. Press the chat header
  4. Press the Share code menu
  5. Press the Download menu to download the QR code, repeat this > 30 times
  6. Verify you can still download the QR code without any error
  7. Verify the current time is appended to the QR code image name (except iOS)

2FA code download

  1. Open Settings > Security > Two-factor authentication
  2. Press the Download button
  3. Verify the current time is appended to the 2fa code file name (on iOS, a Share modal will show instead)

Chat attachment download

  1. Open any chat
  2. Send 3 types of attachments, that is image, video, and other files (e.g., text)
  3. Download the attachment
  4. Verify the current time is appended to the attachment file name (except image on iOS)

To see the file downloaded:
For mWeb/Web, open your Downloads folder
For Android, go to File Manager > Downloads > Expensify
For iOS:

  1. image/video: open the Photos app
  2. others: I can't see the files downloaded on the simulator, so I don't know how to check it, but guessing from the code, it should be in the Documents folder.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
Screenrecorder-2023-07-25-16-51-03-773.mp4
Screenrecorder-2023-07-25-16-50-10-33.mp4
Mobile Web - Safari
ios_mweb.mov
Desktop
desktop.mov
iOS
ios.mov
ios_2fa.mov
ios_others.mov
Screenshot 2023-07-25 at 17 10 39
Android
Screenrecorder-2023-07-25-16-32-50-528.mp4
Screenrecorder-2023-07-25-16-42-29-345.mp4
Screenrecorder-2023-07-25-16-40-33-602.mp4

@bernhardoj bernhardoj requested a review from a team as a code owner July 25, 2023 09:28
@melvin-bot melvin-bot bot requested review from parasharrajat and removed request for a team July 25, 2023 09:28
@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -104,7 +104,7 @@ function getFileType(fileUrl) {
function splitExtensionFromFileName(fullFileName) {
const fileName = fullFileName.trim();
const splitFileName = fileName.split('.');
const fileExtension = splitFileName.pop();
const fileExtension = splitFileName.length > 1 ? splitFileName.pop() : '';
return {fileName: splitFileName.join('.'), fileExtension};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is to fix the file name that is returned as the extension when the file name does not have an extension, for example, if the file name is anyfilename, the fileExtension is anyfilename and the fileName is empty.

This function is being used for attachment validation. Before this change, we can upload a file name jpg because jpg is a valid extension.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks.

@@ -41,7 +41,7 @@ function handleDownload(url, fileName) {

// Android files will download to Download directory
const path = dirs.DownloadDir;
const attachmentName = fileName || FileUtils.getAttachmentName(url);
const attachmentName = FileUtils.appendTimeToFileName(fileName) || FileUtils.getAttachmentName(url);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the fileName is empty (idk when this case could happen), it will generate the file name from the url. FileUtils.getAttachmentName itself appends the current time to the generated file name with a different format, that's why I append the time to fileName only.

function getAttachmentName(url) {
if (!url) {
return '';
}
return `${moment().format('DDMMYYYYHHmmss')}.${url.split(/[#?]/)[0].split('.').pop().trim()}`;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the same pattern for date.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one to follow, the format from getAttachmentName or the new one I created?
getAttachmentName: 24102000163544.[extension],
if we follow the new one, this becomes 2023-07-26T03:58:14.737Z.[extension]

new: [name] - 2023-07-26T03:58:14.737Z.[extension],
if we follow the above, this becomes [name] - 24102000163544.[extension]

Also, I don't found any case for getAttachmentName yet, so we can't test its usage.

Copy link
Member

@parasharrajat parasharrajat Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say let's do the old one (24102000163544). But I don't have any preference. Both works. Feel free to use the one that look best to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to use the date format from DateUtils.getDBTime(). It is the same with the new format, except T is replaced with space and Z is removed. The old format does not have milliseconds which I think is really important to keep it.

@bernhardoj
Copy link
Contributor Author

bernhardoj commented Jul 25, 2023

On iOS, we can't append the current time to the image name. That is because we are using the CameraRoll library to save it and it doesn't have the option to set a name.

function downloadImage(fileUrl) {
return CameraRoll.save(fileUrl);
}

This is how the downloaded image (from iOS) name looks like.
image

So, only the iOS image doesn't have the current time appended to its name, but the other platforms should have it (including iOS mWeb).

@bernhardoj
Copy link
Contributor Author

Added a unit test

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 25, 2023

#23531 (comment)

Does this not exist on iOS?

@bernhardoj
Copy link
Contributor Author

Renamed getAttachmentDetails.

Does this not exist on iOS?

Only for image. CameraRoll library does not have any option to set a custom name when saving it. We just give the CameraRoll the image URL and it will generate the name by itself.
Image URL example:

https://www.expensify.com/chat-attachments/6084074491066043699/w_1eaa2352b526093637a4b486ce57753c7bd9e9fd.gif?encryptedAuthToken=Wy6xxwAutiOCo32CKRslUdhaUlL%2BaLYDrQUgbLe%2FTInhnD%2B4dtviXq5%2FkSVVxS9Ygpvd4YTbICiAum36w%2F%2BZz0nmbNNDHCHlsEsepntDJQua9Puh74RE0Jw5PKOoadBO7U1sNfeRIREtwUqsxpidN41v3HunyDggBhfIwk3Tf2i6J2EgepgL5yPDAAJS1rFFjqx1eR4OOIVeXazps0jyCS7KdJOqJRiPhVWHR0IVeKtHUBhnt6z%2FCZxinL2L50qq%2BCptY0PROj3U03kOPOz1SO7eofQqJmexK4Jg1iojd%2BafGw%2FlcOdYxfXUHo2Nek%2BDLmuFOy0lNf9%2FFPkkXRv0B3C43ATECoEpZDCkth%2FSY25WxMNIkVMwhlwoWgjaS0%2F27lGD%2FC2ExaApyDjgyGcBbanfqoY6jNF3DF%2Fg2JSRvr3ppzyICQfgx5k3ho0s%2Bcwh%2B2Qf1VpxgaHUt7KH5wq%2BSKu8Zanc9BX0q7lEgFZZeFEMuc2diHXD8klqqBbY3ABdQS9uQT1nAYzykpm%2FWz%2BOIk%2BoqUXmrJ52TwSNpFbGCkv39BJtlZGjE3kCTeU3%2BJ1RXDv27OL2zIdDXoF9m9IgWSh6srfoKb26OKQrLmQV4ZEzUNxPhDA5xFS%2Fl6tpUHRmUSLPScYkheSAmuhqGQ34cYjMbsu3CJIBxWtmNT6uAF7yfQGD9ZI5a12OMHgHLFq0pSy8uYT2cWCNpK7MWV2ZXRiEa3piK8rLJTxJXL7cQpke7A95pArP2dOwSq1VSYZr8I92ZazT%2FOXhbbxVNV939ECisaDstx3WLtOuGArrucieE7vd3eP1suumW7J6vIA%2Fa2vV1lEvjKUMLURYNkbKdTeN%2BDWagFtv64w%2BKqfnLlcox7ULIfg0PYZnPPLG3is%2FHKiZ3fWh8cdMUl07fgESO5XqxMWfQurXobGsioCIrBI48XrQQpr%2BY9K9d0e797K2sXMLLPDkvO38Gw2JHruFttqiNtCmOlUHpaxGF1fOF%2BQkTX8sfnCru2ZyPzMJj1Q7ayEuxT2WAHFdiu1%2BuQQaVFy9okH4506EenSTV7gIm4o%3D

We actually use CameraRoll for saving video too, the difference is, for video, we first download it with react-native-blob-util (using downloadFile) and put it to Documents. Then we get the video URI and pass it to CameraRoll. The reason we did this is explained by this comment:

// Because CameraRoll doesn't allow direct downloads of video with remote URIs, we first download as documents, then copy to photo lib and unlink the original file.
downloadFile(fileUrl, fileName)

The video URI looks like this:

/Users/bernhardoj/Library/Developer/CoreSimulator/Devices/D429C55A-6336-46B9-A580-BDF0570ACBD2/data/Containers/Data/Application/C06C26B5-59C3-4ED1-9C98-E39091FE51A2/Documents/Screen_Recording_2023-07-25_at_12.53.30 - 2023-07-26T04:21:56.466Z.mov

I guess that when we pass a URI, CameraRoll will just use its name from the URI.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 26, 2023

So Won't it create the same crash issue for iOS? Or it works/handled there.

@bernhardoj
Copy link
Contributor Author

@parasharrajat I don't know whether iOS has the same limitation, but even if it has, it won't ever happen as the generated image name contains an incremental(?) number, for example, IMG_001, IMG_002, so the name will always be unique.

*/
function appendTimeToFileName(fileName) {
const file = splitExtensionFromFileName(fileName);
let newFileName = `${file.fileName} - ${DateUtils.getDBTime()}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let newFileName = `${file.fileName} - ${DateUtils.getDBTime()}`;
let newFileName = `${file.fileName}-${DateUtils.getDBTime()}`;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@parasharrajat
Copy link
Member

A small request above @bernhardoj.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 27, 2023

Screenshots

🔲 iOS / native

Screen.Recording.2023-07-28.at.12.53.00.AM.mov

🔲 iOS / Safari

Screen.Recording.2023-07-28.at.12.54.07.AM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-07-28.at.12.49.57.AM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-07-28.at.12.49.26.AM.mov

🔲 Android / Chrome

Screen.Recording.2023-07-28.at.12.51.01.AM.mov

🔲 Android / native

Screen.Recording.2023-07-28.at.12.56.10.AM.mov

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from madmax330 July 27, 2023 19:27
@parasharrajat
Copy link
Member

I have requested a small change above but approved it as that change won't make a real difference to the functionality.

@madmax330 madmax330 merged commit 89dfb77 into Expensify:main Aug 1, 2023
11 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2023

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.49-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2023

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.50-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2023

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 7, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

const attachmentName = fileName || FileUtils.getAttachmentName(url);
const attachmentName = FileUtils.appendTimeToFileName(fileName) || FileUtils.getAttachmentName(url);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current logic for determining attachmentName doesn't adequately handle fallback scenarios:

const attachmentName = FileUtils.appendTimeToFileName(fileName) || FileUtils.getAttachmentName(url);
  1. If fileName is undefined, the application will throw an error due to the attempt to append time to it, leading to a failed download.
  2. FileUtils.appendTimeToFileName always returns a value, so we won't ever fall back to FileUtils.getAttachmentName, even in cases where fileName is an empty string.

The previous version of the function handled both of these cases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I think we should do

const attachmentName = fileName ? FileUtils.appendTimeToFileName(fileName) : FileUtils.getAttachmentName(url);

instead. Or should appendTimeToFileName handle the empty (undefined, null, empty string) case?

Btw, are you coming from an issue that is caused by this change? I'm curious to know in what case the fileName is empty. If not, what should I do here? Should I open a PR?

cc: @parasharrajat

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've stumbled on the problem, when I was testing my PR on iOS: #25556

I've already included a fix in my PR

It seems fileName can be undefined for attachments that are send by Concierge, when they embed images via Drag & Drop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks @kidroca for handling that. Let's know if you want any refactors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fileName can be undefined for attachments that are send by Concierge, when they embed images via Drag & Drop

I see. What a unique case. Thanks for catching and handling it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants