Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist notification cache to internal storage #23825
Persist notification cache to internal storage #23825
Changes from all commits
0d201fe
f0d1811
5891d85
9e3452d
43893e2
05cb476
56a1dc1
3bf3bf5
e643107
5ef1f63
43dfbc6
949fb1c
6fa2aac
907fb2e
5170132
17b882d
46687de
e03a51c
dd8f47c
1e06cf0
3704944
6189be7
38f55c0
93fa41e
32f2027
887b1bc
e7188b8
6df512d
f119998
d772757
b396b5e
6b3ff25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case where casting the object to result fails, can we assume it is malformed and wipe it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the file could fail in a few ways, but in any case, the file will get overwritten once we're done processing the notification and update the cache