Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite BaseModal to a functional component #25672

Merged
merged 8 commits into from
Aug 25, 2023
Merged

rewrite BaseModal to a functional component #25672

merged 8 commits into from
Aug 25, 2023

Commits on Aug 22, 2023

  1. rewrite BaseModal to a functional component

    @JKobrynski
    JKobrynski committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3ae6ffa View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. apply minor style changes

    @JKobrynski
    JKobrynski committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    485b4df View commit details
    Browse the repository at this point in the history

  2. wrap getModalStyles with useMemo

    @JKobrynski
    JKobrynski committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d2f2331 View commit details
    Browse the repository at this point in the history

  3. modify dependency arrays, merge two useEffects into one

    @JKobrynski
    JKobrynski committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    379107f View commit details
    Browse the repository at this point in the history

  4. fix eslint disable placement

    @JKobrynski
    JKobrynski committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5fd5ee1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into migrateBaseModal

    @JKobrynski
    JKobrynski committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ee17a26 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'main' into migrateBaseModal

    @JKobrynski
    JKobrynski committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a40077b View commit details
    Browse the repository at this point in the history

  2. format code

    @JKobrynski
    JKobrynski committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7423e68 View commit details
    Browse the repository at this point in the history