[HOLD E/E #311912] Fix/25680: Assignee does not show on Confirm task page

[DylanDylann]

Details

Assignee does not show on Confirm task page because we don't have their personal details yet

Fixed Issues

$ #25680
PROPOSAL: #25680 (comment)

Tests

1. Click on FAB icon and select new chat
2. Enter email and create a new chat
3. Click on FAB icon and select assign a task
4. Enter title and click on Next button
5. Click on assignee and search for user with whom you created new chat
6. Select that user
7. Verify that assignee should show on Confirm task page

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Click on FAB icon and select new chat
2. Enter email and create a new chat
3. Click on FAB icon and select assign a task
4. Enter title and click on Next button
5. Click on assignee and search for user with whom you created new chat
6. Select that user
7. Verify that assignee should show on Confirm task page

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screencast.from.23-08-2023.18.23.29.webm

Mobile Web - Chrome

test.mp4

Mobile Web - Safari

Screen.Recording.2023-08-23.at.17.58.27.mp4

Desktop

Screen.Recording.2023-08-23.at.18.01.47.mp4

iOS

Screen.Recording.2023-08-23.at.18.25.48.mp4

Android

[melvin-bot]

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

@rushatgabhane updated! Please help check my PR

[DylanDylann]

@rushatgabhane @mountiny It seems we just have a new update on the main branch. Now we can't search for new users in the assignee modal. Now we need to confirm the expected
Step:

1. Click on FAB icon and select new chat
2. Enter email and create a new chat

Expected (need to confirm)

1. User still can search this user on assignee modal
2. User can't search this user on assignee modal until this user send the first message

[DylanDylann]

@rushatgabhane please help review my PR, thanks!

[rushatgabhane]

@DylanDylann that looks like a regression. I can't think of any reason why we shouldn't be able to assign a task to any user.

[rushatgabhane]

@DylanDylann could you please merge lates main into your branch

[DylanDylann]

@rushatgabhane merged latest main into my branch

[rushatgabhane]

@DylanDylann for some reason im stuck on the report loading screen when I run this branch. Do you experience the same?

[DylanDylann]

@DylanDylann for some reason im stuck on the report loading screen when I run this branch. Do you experience the same?

no. It is fine from my side

[DylanDylann]

@rushatgabhane @mountiny Currently the PR #25806 is merged to resolve issue #25688 so that we cannot reproduce the issue #25680

[mountiny]

@DylanDylann I think we can revert that cc @marcaaron @thienlnam

@DylanDylann Will your solution work even after signing out and signing back in when the other user exists but they have display name set (in that case the personal details returned wont have login/email)

[DylanDylann]

These steps:

1. Click on FAB icon and select new chat
2. Enter email and create a new chat
3. Logout
4. Login
5. Click on FAB icon and select assign a task
6. Enter title and click on Next button
7. Click on assignee and search for user with whom you created new chat
8. Select that user
9. Verify that assignee should show on Confirm task page

Following the above steps, my solution works properly. Please help re-test. Thanks @mountiny @rushatgabhane

[mountiny]

Click on assignee and search for user with whom you created new chat

this user, do they have display name set up?

[DylanDylann]

@mountiny

do they have display name set up?

No. The email is displayed

[mountiny]

can you try with the dispaly name set, then you wont have the email locally available

[DylanDylann]

@mountiny Follow these steps it works properly: (with the canInviteUser : true)

Steps:

1. Set name for user B
2. Login with user A
3. Click on FAB icon and select new chat
4. Enter email and create a new chat
5. Click on FAB icon and select assign a task
6. Enter title and click on Next button
7. Click on assignee and search for user with whom you created new chat
8. Select that user
9. Verify that assignee should show on Confirm task page

[DylanDylann]

@mountiny Bump
cc @rushatgabhane

[mountiny]

@rushatgabhane could you come back to this one please?

[mountiny]

@DylanDylann #25806 (comment) well it seems like creating a new user through this flow is not supported in BE if I understood this correctly, @rushatgabhane to confirm

[DylanDylann]

@DylanDylann #25806 (comment) well it seems like creating a new user through this flow is not supported in BE if I understood this correctly, @rushatgabhane to confirm

@rushatgabhane please help confirm it. Thanks

[DylanDylann]

@mountiny Bump
cc @rushatgabhane

[mountiny]

Sorry i am mainly busy with the deliverables for the conferences now, we will come back to this later as it seems a bit more intertwined

[rushatgabhane]

Yeah it looks like it's not allowed by the back-end

[thienlnam]

This should still allow optimistic assignees that you haven't chatted with before, but will still fail on contacts that don't exist at all - this is kind of how it was before which is fine

[DylanDylann]

@thienlnam @mountiny @rushatgabhane So should we revert this PR ?

[marcaaron]

Let's verify whether reverting it reintroduces the deploy blocker it was created to resolve?

[marcaaron]

this is kind of how it was before which is fine

Yes, fine, except the part about the app crashing when you try to do it and they don't exist - that was introduced and is not fine 😄

[DylanDylann]

@mountiny @marcaaron @thienlnam This PR, we don't allow users to assign to assignees that you haven't chatted with before and don't exist at all. But as the comment from @thienlnam

This should still allow optimistic assignees that you haven't chatted with before, but will still fail on contacts that don't exist at all - this is kind of how it was before which is fine

we only don't allow users to assign to assignees who don't exist at all.

So, I think we should revert this PR and create another PR to fix this issue as the correct expected.

Please correct me if I am wrong

[mountiny]

Ok, yeah I think the expected behaviour and the easiest for now until this is updated across stack is just to allow assinging people you have in the personalDetails

@thienlnam @marcaaron do you agree?

[thienlnam]

Yes, fine, except the part about the app crashing when you try to do it and they don't exist - that was introduced and is not fine 😄

Yeah indeed, though a recent PR introduced that regression not the original PR that allowed this
I'm kind of agreeing with Vit here on doing nothing and closing this PR here as it's not really a priority.

I have a follow up issue to handle assignees that don't exist yet in the BE. We can just address this after that follow up issue is done

[marcaaron]

we should revert #25806 and create another PR to fix #25688 as the correct expected

fwiw, the order of operations here sounds wrong. The change we made was small so just "revert" and fix it in the same PR.

[DylanDylann]

@thienlnam @mountiny

I have a follow up issue to handle assignees that don't exist yet in the BE. We can just address this after that follow up issue is done

So we should hold this PR until the BE change is done

[mountiny]

@thienlnam could you put this on hold for the backend PR you got in works?