Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed composer not catching paste events when unfocused #25900

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Fixed composer not catching paste events when unfocused #25900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909512b
updated composer paste handling to only return early if the target wa…
joh42 Aug 24, 2023
8f21322
added comment explaining composer paste handling early return
joh42 Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/Composer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,14 @@ function Composer({
}

if (textInput.current !== event.target) {
return;
// To make sure the composer does not capture paste events from other inputs, we check where the event originated
// If it did originate in another input, we return early to prevent the composer from handling the paste
const isTargetInput = event.target.nodeName === 'INPUT' || event.target.nodeName === 'TEXTAREA' || event.target.contentEditable === 'true';
joh42 marked this conversation as resolved.
Show resolved Hide resolved
if (isTargetInput) {
return;
}

textInput.current.focus();
}

event.preventDefault();
Expand Down
Loading