Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks" #25963

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

mountiny
Copy link
Contributor

Straight revert of #25866

@mountiny mountiny requested a review from a team as a code owner August 25, 2023 17:59
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team August 25, 2023 17:59
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Fixing the race condition on history.go due to buggy queue async callbacks" [NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks" Aug 25, 2023
@thienlnam thienlnam merged commit 8fcfb4f into main Aug 25, 2023
12 of 15 checks passed
@thienlnam thienlnam deleted the revert-25866-react-navigation-native-fix branch August 25, 2023 18:06
@melvin-bot melvin-bot bot added the Emergency label Aug 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@thienlnam
Copy link
Contributor

Merged without passing checklists since this is a straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.59-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants