Map panning fix #25977

gegham-khachatryan · 2023-08-25T21:03:11Z

Details

Fixed Issues

$ #25732

PROPOSAL: #25732 (comment)

Tests

Click the "+" icon next to the chat message text field. Click "Request Money" on the pop up menu that appears.
Check "Distance" tab on the Right Hand Panel that appears
Click the "Start" item from the list of waypoints.
In the text field that appears in the next screen, type "88 Kearny Street". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.
Map camera flied to selected address where marker is visible.
Click Add Step button
Click on new added step
In the text field that appears in the next screen, type "Golden Gate Park". Click the first option "Golden Gate Pkwy, Naples, FL, USA" that appears.
Verify that the 2 markers are on the map and camera moved to show both on the screen.
Added Finish step
Verify that the distance was drawn as expected.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click the "+" icon next to the chat message text field. Click "Request Money" on the pop up menu that appears.
Check "Distance" tab on the Right Hand Panel that appears
Click the "Start" item from the list of waypoints.
In the text field that appears in the next screen, type "88 Kearny Street". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.
Map camera flied to selected address where marker is visible.
Click Add Step button
Click on new added step
In the text field that appears in the next screen, type "Golden Gate Park". Click the first option "Golden Gate Pkwy, Naples, FL, USA" that appears.
Verify that the 2 markers are on the map and camera moved to show both on the screen.
Added Finish step
Verify that the distance was drawn as expected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.-.Screen.Recording.2023-08-26.at.09.52.07.mov

Mobile Web - Chrome

Web.Mobile.Chrome.-.iPhone.14.Pro.MP4

Mobile Web - Safari

Web.Mobile.Safari.-.Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-08-26.at.09.39.49.mp4

Desktop

Screen.Recording.2023-08-26.at.10.28.32.mov

iOS

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-08-26.at.00.58.04.mp4

Android

Screen.Recording.2023-08-26.at.16.34.28.mov

Added new props to avoid introducing unnecessary dependencies ('@react-navigation/native') to the 'react-native-x-maps' library.

melvin-bot · 2023-08-25T21:03:16Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-08-25T21:03:29Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

allroundexperts · 2023-08-25T21:12:33Z

Hi @gegham-khachatryan!
Just a heads up. You're required to check all the checkboxes in the checklist. Also, you need to test and upload screen recordings of all of the platforms (not just iOS). Please sign the CLA as well!

gegham-khachatryan · 2023-08-26T04:40:46Z

I have read the CLA Document and I hereby sign the CLA

allroundexperts · 2023-08-26T09:05:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-01.at.2.30.23.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-01.at.2.48.03.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-01.at.2.37.04.AM.mov

Desktop

Screen.Recording.2023-09-01.at.3.07.59.AM.mov

iOS

Screen.Recording.2023-09-01.at.2.33.23.AM.mov

Android

Screen.Recording.2023-09-01.at.3.03.36.AM.mov

gegham-khachatryan · 2023-08-26T12:39:30Z

Hi @gegham-khachatryan! Just a heads up. You're required to check all the checkboxes in the checklist. Also, you need to test and upload screen recordings of all of the platforms (not just iOS). Please sign the CLA as well!

Hi @allroundexperts Testing done, screen recordings attached.

hayata-suenaga · 2023-08-29T22:46:02Z

is this one good to go once this PR is merged?

allroundexperts · 2023-08-29T22:47:38Z

We'll still need to do a final round of testing IMO.

…ning-fix # Conflicts: # src/CONST.ts # src/components/DistanceRequest.js

…ning-fix

melvin-bot · 2023-08-30T15:44:49Z

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

neil-marcellini · 2023-08-30T15:45:24Z

I added #25977 to the fixed issues. @gegham-khachatryan Would you please include a test a video showing that it's solved?

gegham-khachatryan · 2023-08-30T16:10:14Z

@neil-marcellini screen recordings here #25977 (comment)

hayata-suenaga · 2023-08-30T17:18:29Z

@gegham-khachatryan is this ready for review?

gegham-khachatryan · 2023-08-30T18:01:38Z

@gegham-khachatryan is this ready for review?

Yes @hayata-suenaga It's ready. I fixed also regression issue.

allroundexperts · 2023-08-30T18:02:45Z

Thanks. Starting the testing again.

JmillsExpensify · 2023-08-30T21:29:48Z

How's testing going?

allroundexperts · 2023-08-30T21:31:43Z

Good so far!

@gegham-khachatryan Can you make sure that your commits are signed?

This is causing a check to fail.

gegham-khachatryan · 2023-08-30T21:40:44Z

Good so far!

@gegham-khachatryan Can you make sure that your commits are signed?

This is causing a check to fail.
@allroundexperts It seems not 😏 Is there any way to sign them?

allroundexperts · 2023-08-30T21:44:52Z

Take a look at this guide.

parasharrajat · 2023-09-01T09:19:21Z

src/components/MapView/Direction.web.tsx

+                    id="route"
+                    type="geojson"
+                    data={{
+                        type: 'Feature',
+                        properties: {},
+                        geometry: {
+                            type: 'LineString',
+                            coordinates,
+                        },
+                    }}
+                >
+                    <Layer
+                        id="route"


Use different ids for layer and source and keep these the same as native varient.

Technically, we don't need to pass these ids. given that we are not using this our logic and lib will assign default ones.

parasharrajat · 2023-09-01T09:20:07Z

src/components/MapView/Direction.web.tsx

+                    <Layer
+                        id="route"
+                        type="line"
+                        source="route"


Suggested change

source="route"

Beacuse it is nested in a Source so let's remove it for less confusion.

parasharrajat · 2023-09-01T09:21:21Z

src/components/MapView/Direction.web.tsx

+                    data={{
+                        type: 'Feature',
+                        properties: {},
+                        geometry: {
+                            type: 'LineString',
+                            coordinates,
+                        },
+                    }}


Better to move this data in mapView utils.ts file as a function which takes coordinates as parameter.

parasharrajat · 2023-09-01T09:24:45Z

src/components/MapView/MapView.web.tsx

let's rename it to index.tsx. This is also used for desktop right? It is good to follow existing patterns.

parasharrajat · 2023-09-01T09:25:07Z

src/components/MapView/MapView.tsx

Rename it to index.native.tsx.

parasharrajat · 2023-09-01T09:39:20Z

src/components/MapView/MapView.tsx

+    return (
+        <View style={style}>
+            <Mapbox.MapView
+                style={{flex: 1}}


No line styles , use Styles.flex1

parasharrajat · 2023-09-01T09:40:48Z

src/components/MapView/MapView.web.tsx

+            map.fitBounds([northEast, southWest], {padding: mapPadding});
+        }, [waypoints, mapRef, mapPadding]);
+
+        useImperativeHandle(


Same here we can pass type parameters.

parasharrajat · 2023-09-01T09:41:39Z

src/components/MapView/MapView.web.tsx

+                return;
+            }
+
+            if (waypoints.length === 1) {


Please add comment for explanation.

src/components/MapView/MapView.web.tsx

parasharrajat · 2023-09-01T09:48:28Z

src/components/MapView/Direction.web.tsx

Please create a child folder Direction in Mapview and then create this file as index.tsx. for native file, name would be index.native.tsx

parasharrajat · 2023-09-01T09:56:49Z

When we select a very long route, no path line is shown. It might be fine.

parasharrajat · 2023-09-01T09:59:35Z

I added the last stop to a far place in the US and Mapbox threw a tile load error. Technically, this is out of our hands.

Bug: Map stopped responding after tile load error.

Steps:

Add three points in US single state.
Add last stop to somewhere in India.
If load error is shown, try deleting waypoints and observe that the map does not pan anymore.

hayata-suenaga · 2023-09-01T14:25:53Z

When we select a very long route, no path line is shown. It might be fine.

yes it's fine 👍 not a blocker

Add three points in US single state.
Add last stop to somewhere in India.

No one drives from the US to India 😅 It's fine

hayata-suenaga · 2023-09-01T14:30:13Z

@gegham-khachatryan please urgently address the review comments

@allroundexperts @gegham-khachatryan I think all review comments right now are not blocker. If the CI tests pass, I think it's good to merge. What do you think?

We can address all these review comments in a follow up PR

allroundexperts · 2023-09-01T14:30:25Z

No one drives from the US to India 😅 It's fine

But people do travel by air. Would that mean that they'll not be able to refund there ticket?

allroundexperts · 2023-09-01T14:31:23Z

Sounds good to me @hayata-suenaga. Also, I think we're increasing scope of this PR by keep on adding new things to it. Would be best to create a followup PR.

hayata-suenaga · 2023-09-01T14:33:14Z

But people do travel by air. Would that mean that they'll not be able to refund there ticket?

This distance request is mainly to reimburse expenses for gas when people travel by car

Sounds good to me @hayata-suenaga. Also, I think we're increasing scope of this PR by keep on adding new things to it. Would be best to create a followup PR.

I agree 👍

hayata-suenaga · 2023-09-01T14:34:01Z

@gegham-khachatryan

gegham-khachatryan · 2023-09-01T16:06:52Z

@gegham-khachatryan please urgently address the review comments

@allroundexperts @gegham-khachatryan I think all review comments right now are not blocker. If the CI tests pass, I think it's good to merge. What do you think?

We can address all these review comments in a follow up PR

Sure, @hayata-suenaga, I'll review the comments. I'm not sure if it's a good time to implement @parasharrajat's recommendations.

gegham-khachatryan · 2023-09-01T16:11:45Z

@gegham-khachatryan

Fixed. I missed import during conflict resolution

gegham-khachatryan · 2023-09-01T16:23:51Z

@allroundexperts I cannot sign previous commits. I would greatly appreciate it if you could assist me in doing so.

hayata-suenaga · 2023-09-01T16:24:12Z

yes let's open another PR to implement @parasharrajat's suggestions

allroundexperts · 2023-09-01T16:34:19Z

@allroundexperts I cannot sign previous commits. I would greatly appreciate it if you could assist me in doing so.

@gegham-khachatryan I would use something like git rebase -S -i HEAD~14

Lemme know if this works.

PS: I took this from https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

hayata-suenaga · 2023-09-01T16:40:29Z

@gegham-khachatryan ⬆️ 😃

parasharrajat · 2023-09-01T16:43:42Z

So I understand that no one will travel from India to the US but that was just a step to reproduce the issue. The main issue is that afterward when we add/remove waypoints in the US itself. The map does not work. Due to an error, it stops functioning.

We should definitely fix my suggestions as there are some architectural gaps which break our standards. It is fine to do this in follow-up.

gegham-khachatryan · 2023-09-01T16:46:13Z

@allroundexperts I looks impossible 😃 need to solve 463 conflicts, I don't know why)) I can create PR inside my fork, merge with squash, and open new PR with single commit to Expensify/main

allroundexperts · 2023-09-01T16:50:06Z

@allroundexperts I looks impossible 😃 need to solve 463 conflicts, I don't know why)) I can create PR inside my fork, merge with squash, and open new PR with single commit to Expensify/main

@hayata-suenaga Would that work? cc @parasharrajat since you're the more experienced here.

parasharrajat · 2023-09-01T16:52:09Z

Yeah, merge with squash is fine. let's try that. It is helpful for the future to keep the original PR where the discussion happened so I won't suggest creating a new one.

…ning-fix # Conflicts: # src/components/DistanceRequest.js

hayata-suenaga · 2023-09-01T17:24:19Z

@gegham-khachatryan we have another set of ESLint issues now 😓

gegham-khachatryan · 2023-09-01T17:57:15Z

@hayata-suenaga #26500
New PR opened. Lint errors fixed

neil-marcellini · 2023-09-01T19:53:57Z

Closed in favor of the new PR

gegham-khachatryan added 2 commits August 25, 2023 23:13

Fix Map Panning behavior

3db5935

Add screen focus state props to MapView

1dbc119

Added new props to avoid introducing unnecessary dependencies ('@react-navigation/native') to the 'react-native-x-maps' library.

gegham-khachatryan requested a review from a team as a code owner August 25, 2023 21:03

melvin-bot bot removed the request for review from a team August 25, 2023 21:03

melvin-bot bot requested a review from allroundexperts August 25, 2023 21:03

gegham-khachatryan mentioned this pull request Aug 25, 2023

Fix Map Panning issue Expensify/react-native-x-maps#32

Closed

gegham-khachatryan added 4 commits August 30, 2023 11:42

feat: Move code from react-native-x-maps to the App

20fe5e7

Merge branch 'main' of github.com:gegham-khachatryan/App into map-pan…

9b012b7

…ning-fix # Conflicts: # src/CONST.ts # src/components/DistanceRequest.js

fix: rename mapbox consts

2405b2c

Merge branch 'main' of github.com:gegham-khachatryan/App into map-pan…

6cf632c

…ning-fix

gegham-khachatryan added 2 commits August 30, 2023 20:38

fix: Fix app crashing on waypoint delete

5639067

Remove unnecessary re exports

cb6cb07

parasharrajat suggested changes Sep 1, 2023

View reviewed changes

fix: add PropTypes import which is mised during conflict resolution

9af7e4e

Merge branch 'main' of github.com:gegham-khachatryan/App into map-pan…

042a9f8

…ning-fix # Conflicts: # src/components/DistanceRequest.js

allroundexperts mentioned this pull request Sep 1, 2023

Map panning fix (2) #26500

Merged

59 tasks

neil-marcellini approved these changes Sep 1, 2023

View reviewed changes

neil-marcellini closed this Sep 1, 2023

ahmedGaber93 mentioned this pull request Sep 10, 2023

[HOLD for payment 2023-10-09] [$500] Web - App displays waypoint address page briefly on click on 'Go back to Home page' #27106

Closed

6 tasks

This was referenced Sep 11, 2023

[HOLD for payment 2023-09-11] [$2000] Fix issue with Map panning behavior #25732

Closed

Small cleanup #27507

Closed

Map panning fix #25977

Map panning fix #25977

Conversation

gegham-khachatryan commented Aug 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 25, 2023

github-actions bot commented Aug 25, 2023 • edited Loading

allroundexperts commented Aug 25, 2023

gegham-khachatryan commented Aug 26, 2023

allroundexperts commented Aug 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

gegham-khachatryan commented Aug 26, 2023 • edited Loading

hayata-suenaga commented Aug 29, 2023

allroundexperts commented Aug 29, 2023

melvin-bot bot commented Aug 30, 2023

neil-marcellini commented Aug 30, 2023

gegham-khachatryan commented Aug 30, 2023

hayata-suenaga commented Aug 30, 2023

gegham-khachatryan commented Aug 30, 2023

allroundexperts commented Aug 30, 2023

JmillsExpensify commented Aug 30, 2023

allroundexperts commented Aug 30, 2023

gegham-khachatryan commented Aug 30, 2023

allroundexperts commented Aug 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat commented Sep 1, 2023

parasharrajat commented Sep 1, 2023 • edited Loading

hayata-suenaga commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

allroundexperts commented Sep 1, 2023 • edited Loading

hayata-suenaga commented Sep 1, 2023

parasharrajat commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

parasharrajat commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

neil-marcellini commented Sep 1, 2023

gegham-khachatryan commented Aug 25, 2023 •

edited

Loading

github-actions bot commented Aug 25, 2023 •

edited

Loading

allroundexperts commented Aug 26, 2023 •

edited

Loading

gegham-khachatryan commented Aug 26, 2023 •

edited

Loading

parasharrajat commented Sep 1, 2023 •

edited

Loading

allroundexperts commented Sep 1, 2023 •

edited

Loading