Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications for editing money requests #27299

Merged
merged 18 commits into from
Sep 26, 2023
Merged

Notifications for editing money requests #27299

merged 18 commits into from
Sep 26, 2023

Commits on Sep 12, 2023

  1. allow other types of notifications

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d0b45ec View commit details
    Browse the repository at this point in the history

  2. rename action to reportAction

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    93a5891 View commit details
    Browse the repository at this point in the history

  3. use formatting for modified expense notifications

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cabe7a5 View commit details
    Browse the repository at this point in the history

  4. only allow some types of actions for notifications

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ada2432 View commit details
    Browse the repository at this point in the history

  5. use report action user as title

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    d74bc4e View commit details
    Browse the repository at this point in the history

  6. use icon on web

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1cc8736 View commit details
    Browse the repository at this point in the history

  7. log reason for no notification

    @arosiclair
    arosiclair committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b6be992 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. use the alert in the payload as the notification message

    @arosiclair
    arosiclair committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6db3f48 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. add comment for matching the backend

    @arosiclair
    arosiclair committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    0223dc5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Expensify/App into arosiclair-dista… 

    …nce-edit-notifications
    @arosiclair
    arosiclair committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    127c0a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Merge branch 'main' of github.com:Expensify/App into arosiclair-dista… 

    …nce-edit-notifications
    @arosiclair
    arosiclair committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    5f80689 View commit details
    Browse the repository at this point in the history

  2. fix selecting the wrong report action to notify for

    @arosiclair
    arosiclair committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    9ed14a9 View commit details
    Browse the repository at this point in the history

  3. suppress false positives

    @arosiclair
    arosiclair committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    eceb13f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'main' of github.com:Expensify/App into arosiclair-dista… 

    …nce-edit-notifications
    @arosiclair
    arosiclair committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f6c2b2a View commit details
    Browse the repository at this point in the history

  2. use comma with space separator

    @arosiclair
    arosiclair committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    63ecfa2 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. add jsdocs

    @arosiclair
    arosiclair committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    682be4a View commit details
    Browse the repository at this point in the history

  2. add notifiable actionName

    @arosiclair
    arosiclair committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b173012 View commit details
    Browse the repository at this point in the history

  3. DRY up notification params 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @arosiclair @marcaaron
    arosiclair and marcaaron authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b8791c3 View commit details
    Browse the repository at this point in the history