-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Onyx failureData on fetch failure #27650
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7f7c23c
fix failure data update on fetch failure
luacmartins 01181bf
return promise
luacmartins db65e70
fix tests
luacmartins 2d03318
Merge branch 'main' into cmartins-fixFailedToFetch
luacmartins fbaaac8
apply failureData for fetch failures
luacmartins e663d93
apply onyx update for requests without response
luacmartins d4bbf03
use optional chaining
luacmartins 2cf25c1
fix style
luacmartins 51cf955
Merge branch 'main' into cmartins-fixFailedToFetch
luacmartins 5e8de92
revert changes, use empty object default for response
luacmartins 1ec33c5
resolve conflicts
luacmartins 6a40f69
fix style
luacmartins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's case of
response = null
, which will make crash on this line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't come across that case yet since I've only seen response = undefined or an actual response object. I could add the null check back if we think it's valuable