Display smartscan errors BELOW the field #27735

Gonals · 2023-09-19T03:42:32Z

Details

Fixed Issues

#26832
PROPOSAL:

Tests

Set up Smartscan if you haven't yet. I'd recommend clearing any existing receipts in there to make this easier.
Run bwm.sh
Create a new receipt money request from newDot by going to + -> Request Money -> Scan and sending a random image. A "Smartscanning" transaction should be created.
Wait for a bit for bwm to do its thing (you are waiting for SmartScan?receiptID=XXX).
Log into expensify.com.dev/expensiworks/
Find the receipt you just uploaded (if you cleared up the other ones, it'll be the only one!) and indicate you don't know the amount.
Wait for another bit for bwm to do its thing (confirm nothing fails)
Confirm the Money Request fields get update correctly, with the missing fields. The errors should be BELOW the fields now:

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Create a new receipt money request from newDot by going to + -> Request Money -> Scan and sending a receipt with a missing amount. A "Smartscanning" transaction should be created.
Wait until it smartscans (can take a while)
Confirm the Money Request fields get updated correctly, with the missing fields. Confirm the errors are BELOW the fields:

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-19T03:43:05Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2023-09-19T08:26:33Z

Screenshots added. Ready for review, @cristipaval!

Gonals · 2023-09-22T06:08:47Z

bump @cristipaval !

cristipaval · 2023-09-24T21:17:46Z

Added @sobitneupane as he seems to be the C+ assigned to the issue. I don't know why Melvin did not assign him in the first place.

cristipaval · 2023-09-24T21:18:04Z

I'll review after, @sobitneupane

Gonals · 2023-09-25T06:40:43Z

I don't know why Melvin did not assign him in the first place.

C+ can't really fully test, as this requires handling smartscan and they don't have access to it

cristipaval · 2023-09-25T12:35:51Z

aah, good point @Gonals, I'll test it then 👍

cristipaval · 2023-09-25T20:54:33Z

Expensiworks is driving me crazy! I just can't make it show an uploaded receipt, BWM keeps retrying to parse the receipts

I'm going to try again tomorrow as I already spent some time on this. Feel free to also reassign, @Gonals

Gonals · 2023-09-26T03:16:28Z

@sobitneupane, you may be able to test this by uploading a receipt with no merchant and waiting for it to get smartscanned.

Alternatively, try uploading this receipt. It should automatically parse after a few seconds (maybe a bit longer). After that, changing the Merchant to Unknown Merchant should trigger the error message.

Can you give it a shot?

sobitneupane · 2023-09-26T06:43:21Z

Working on it now.

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-26T07:34:02Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-09-26T07:34:07Z

🎯 @sobitneupane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28231.

sobitneupane · 2023-09-26T07:36:50Z

Just to confirm:

We are showing Red Dot on Report and not on the transaction thread.

Julesssss · 2023-09-27T05:00:27Z

@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: HERE

This seems to have been a bug ^ Ignoring

cristipaval · 2023-09-27T09:45:29Z

Alright, managed to test this one on my local env. It looks like @aimane-chnaif already tested on all platforms. I will merge this.

aimane-chnaif · 2023-09-27T12:04:57Z

src/components/MenuItem.js

@@ -266,6 +266,11 @@ const MenuItem = React.forwardRef((props, ref) => {
                                                {props.description}
                                            </Text>
                                        )}
+                                        {props.error && (


Alright, managed to test this one on my local env. It looks like @aimane-chnaif already tested on all platforms. I will merge this.

I tested but console error is very annoying, happening on every page which uses MenuItem.

Screen.Recording.2023-09-27.at.12.57.23.PM.mov

I raised quick PR to fix that:
#28314

OSBotify · 2023-09-28T19:17:31Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:21:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:50:04Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:51:01Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add error property

a50b87d

Gonals requested a review from a team as a code owner September 19, 2023 03:42

Gonals self-assigned this Sep 19, 2023

melvin-bot bot requested review from cristipaval and removed request for a team September 19, 2023 03:43

Gonals added 2 commits September 19, 2023 12:28

change for all fields

ab503d7

remove subtitle style

c9c13de

Gonals changed the title ~~[WIP] Display smartscan errors BELOW the field~~ Display smartscan errors BELOW the field Sep 19, 2023

cristipaval requested a review from sobitneupane September 24, 2023 21:17

cristipaval approved these changes Sep 25, 2023

View reviewed changes

sobitneupane approved these changes Sep 26, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss September 26, 2023 07:34

melvin-bot bot mentioned this pull request Sep 26, 2023

Payment issue for E/App PR#27735 - Due October 10th, 2023 #28231

Closed

cristipaval merged commit cf9ad20 into main Sep 27, 2023
17 of 18 checks passed

cristipaval deleted the alberto-moveError branch September 27, 2023 09:45

aimane-chnaif mentioned this pull request Sep 27, 2023

fix console error on MenuItem #28314

Merged

58 tasks

aimane-chnaif reviewed Sep 27, 2023

View reviewed changes

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

lanitochka17 mentioned this pull request Sep 29, 2023

[HOLD for payment 2023-10-13] Request money - Merchant scan error is not below the merchant field #28498

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

cristipaval mentioned this pull request Oct 25, 2023

Payment issue for E/App PR#28314 - Due October 25th, 2023 #30344

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display smartscan errors BELOW the field #27735

Display smartscan errors BELOW the field #27735

Gonals commented Sep 19, 2023 •

edited

Loading

melvin-bot bot commented Sep 19, 2023

Gonals commented Sep 19, 2023

Gonals commented Sep 22, 2023

cristipaval commented Sep 24, 2023

cristipaval commented Sep 24, 2023

Gonals commented Sep 25, 2023

cristipaval commented Sep 25, 2023

cristipaval commented Sep 25, 2023

Gonals commented Sep 26, 2023

sobitneupane commented Sep 26, 2023

sobitneupane left a comment

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

sobitneupane commented Sep 26, 2023

Julesssss commented Sep 27, 2023

cristipaval commented Sep 27, 2023

aimane-chnaif Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Display smartscan errors BELOW the field #27735

Display smartscan errors BELOW the field #27735

Conversation

Gonals commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 19, 2023

Gonals commented Sep 19, 2023

Gonals commented Sep 22, 2023

cristipaval commented Sep 24, 2023

cristipaval commented Sep 24, 2023

Gonals commented Sep 25, 2023

cristipaval commented Sep 25, 2023

cristipaval commented Sep 25, 2023

Gonals commented Sep 26, 2023

sobitneupane commented Sep 26, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Sep 26, 2023

melvin-bot bot commented Sep 26, 2023

sobitneupane commented Sep 26, 2023

Julesssss commented Sep 27, 2023

cristipaval commented Sep 27, 2023

aimane-chnaif Sep 27, 2023

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Gonals commented Sep 19, 2023 •

edited

Loading