Fixing incorrect message timing display when changing timezones #27838

abzokhattab · 2023-09-20T08:05:25Z

Details

Changes:
Replaced the isToday, isTomorrow, isYesterday functions imported from date-fns to consider timezones

Fixed Issues

$ #26477
PROPOSAL: #26477 (comment)

Tests

Verify that no errors appear in the JS console
- set user A timezone to be a day ahead and send a message from user A to B, notice that Today is shown in the message timing for both user instead of Tomorrow:

1- Open the app and login with user A
2- Set your timezone to a timezone that will currently have previous day or next day
3- login with user B and set to to a timezone that will have the same day as today
5- From user A, send message to user B and observe that it displays 'Today' for both users

Offline tests

QA Steps

Verify that no errors appear in the JS console
- set user A timezone to be a day ahead and send a message from user A to B, notice that Today is shown in the message timing for both user instead of isTomorrow

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-07.at.6.46.08.AM.mov

iOS

Screen.Recording.2023-09-25.at.1.03.00.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-25.at.1.34.08.PM.mov

Android

Screen.Recording.2023-09-25.at.4.20.10.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-25.at.3.53.32.PM.mov

Desktop

Screen.Recording.2023-09-25.at.2.12.05.PM.mov

…der timezones

melvin-bot · 2023-09-20T08:05:31Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-09-20T08:05:40Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

abzokhattab · 2023-09-20T08:09:21Z

I have read the CLA Document and I hereby sign the CLA

recheck

burczu · 2023-09-25T06:56:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

27838-web.mov

Mobile Web - Chrome

27838-web-chrome.mov

Mobile Web - Safari

27838-web-safari.mov

Desktop

27838-desktop.mov

iOS

27838-ios.mov

Android

27838-android.mov

burczu · 2023-09-25T07:03:35Z

@abzokhattab Videos for platforms other than web are missing - please update it.

abzokhattab · 2023-09-25T13:26:15Z

Videos for other platforms are now available! @burczu

burczu

Reviewed, tested and approved.

johnmlee101

Can you please add automated tests to this file to take account timeZone testing for a good spread, since this affects many locations
https://github.com/Expensify/App/blob/44b87bf1e7f56e0bfdae250de8575c577e8eb58f/tests/unit/DateUtilsTest.js

abzokhattab · 2023-09-26T08:17:12Z

Okay, @johnmlee101 I added some unit tests for this change.

All tests are passing

OSBotify · 2023-09-26T08:47:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:19:24Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:23:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:51:58Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:52:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Beamanator · 2023-11-06T07:34:13Z

tests/unit/DateUtilsTest.js

+        it('isToday should correctly identify today', () => {
+            expect(DateUtils.isToday(todayInTimezone, timezone)).toBe(true);
+            expect(DateUtils.isToday(tomorrowInTimezone, timezone)).toBe(false);
+            expect(DateUtils.isToday(yesterdayInTimezone, timezone)).toBe(false);


FYI it looks like this is failing in early timezones like mine - see https://expensify.slack.com/archives/C01GTK53T8Q/p1699255028952729?thread_ts=1699253289.471629&cid=C01GTK53T8Q

This isn't a HUGE problem since most of our devs are in later timezones, but it's a bit annoying for me :D

Let me know if these changes make sense to you @abzokhattab - they are currently passing for me: #30900

I'll run these tests again in 20 minutes, when Los Angeles becomes the same day as me :D

Interesting!

i still don't get the difference between the two approaches, aren't they returning the same result? no?

I will try to look into it a bit more early my timezone - I agree they look like the same approach, but somehow this let my updated test pass 😅

Customizing the isToday & isTomorrow & isYesterday functions to consi…

fd9f36e

…der timezones

abzokhattab requested a review from a team as a code owner September 20, 2023 08:05

melvin-bot bot requested review from burczu and removed request for a team September 20, 2023 08:05

burczu approved these changes Sep 26, 2023

View reviewed changes

melvin-bot bot requested a review from johnmlee101 September 26, 2023 05:32

johnmlee101 requested changes Sep 26, 2023

View reviewed changes

Adding unit tests for isToday, isTomorrow and isYesterday

114e047

abzokhattab requested a review from johnmlee101 September 26, 2023 08:17

johnmlee101 approved these changes Sep 26, 2023

View reviewed changes

johnmlee101 merged commit 44568ba into Expensify:main Sep 26, 2023
13 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-09] [$500] Chat - 'Yesterday' is displayed even when new messages are sent #26477

Closed

6 tasks

Beamanator reviewed Nov 6, 2023

View reviewed changes

Beamanator mentioned this pull request Nov 6, 2023

Make timezone checks work for early timezone #30900

Closed

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing incorrect message timing display when changing timezones #27838

Fixing incorrect message timing display when changing timezones #27838

abzokhattab commented Sep 20, 2023 •

edited

Loading

melvin-bot bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 •

edited

Loading

abzokhattab commented Sep 20, 2023 •

edited

Loading

burczu commented Sep 25, 2023 •

edited

Loading

burczu commented Sep 25, 2023

abzokhattab commented Sep 25, 2023 •

edited

Loading

burczu left a comment

johnmlee101 left a comment

abzokhattab commented Sep 26, 2023

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Beamanator Nov 6, 2023 •

edited

Loading

Beamanator Nov 6, 2023

abzokhattab Nov 6, 2023 •

edited

Loading

Beamanator Nov 7, 2023

Fixing incorrect message timing display when changing timezones #27838

Fixing incorrect message timing display when changing timezones #27838

Conversation

abzokhattab commented Sep 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2023

github-actions bot commented Sep 20, 2023 • edited Loading

abzokhattab commented Sep 20, 2023 • edited Loading

burczu commented Sep 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu commented Sep 25, 2023

abzokhattab commented Sep 25, 2023 • edited Loading

burczu left a comment

Choose a reason for hiding this comment

johnmlee101 left a comment

Choose a reason for hiding this comment

abzokhattab commented Sep 26, 2023

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Beamanator Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Beamanator Nov 6, 2023

Choose a reason for hiding this comment

abzokhattab Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Beamanator Nov 7, 2023

Choose a reason for hiding this comment

abzokhattab commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023 •

edited

Loading

abzokhattab commented Sep 20, 2023 •

edited

Loading

burczu commented Sep 25, 2023 •

edited

Loading

abzokhattab commented Sep 25, 2023 •

edited

Loading

Beamanator Nov 6, 2023 •

edited

Loading

abzokhattab Nov 6, 2023 •

edited

Loading