Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config settings into environment files #283

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Move config settings into environment files #283

merged 1 commit into from
Aug 24, 2020

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 21, 2020

Fixes #158

Tests

  1. Run cp .env.example .env and edit .env to have your local config options
  2. Just boot up any app and make sure it's working

@tgolen tgolen self-assigned this Aug 21, 2020
roryabraham
roryabraham approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍
However, just in case people are already working on this repo, maybe we should send out an [Action Required] email to let people know that they should re-create their .env file per the instructions in the README

@roryabraham roryabraham merged commit 7f5b580 into master Aug 24, 2020
@roryabraham roryabraham deleted the tgolen-cleanup-env branch August 24, 2020 05:12
@Jag96 Jag96 mentioned this pull request Aug 31, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

Assignees

@tgolen tgolen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move some options from CONFIG.js to the .env files
2 participants
@tgolen @roryabraham