Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand web TextInput as the user types #284

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 21, 2020

Fixes #103

Tests

  1. Type in the textbox on web, android, and iOS, confirm the textbox grows as you type
  2. Delete text in the textbox using backspace, confirm the textbox resizes as you delete
  3. Paste a chunk of text or delete a chunk of text, confirm the textbox resizes properly

@Jag96 Jag96 requested a review from marcaaron August 21, 2020 23:06
@Jag96 Jag96 self-assigned this Aug 21, 2020
@Jag96
Copy link
Contributor Author

Jag96 commented Aug 21, 2020

Going to be OOO until 8/31, if this needs to be updated feel free to ping somebody else to update. If not, I'll get back to it then!

@marcaaron
Copy link
Contributor

Just wondering should we put a limit on the height of the text box?

Screenshot 1263

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well!

@marcaaron
Copy link
Contributor

Gonna hold off merging this until next week in case it breaks something (doesn't look like it should)

@shawnborton
Copy link
Contributor

What's the latest on this one?

@shawnborton
Copy link
Contributor

I agree that a max-height for the input would be great.

@JmillsExpensify
Copy link

Heads up, I just moved the related issue to high. We're already running into this on a daily basis, and is a very important component of moving DMs into RNC.

@marcaaron marcaaron merged commit ecfd8c6 into master Aug 27, 2020
@marcaaron marcaaron deleted the joe-expand-web-text branch August 27, 2020 22:42
@marcaaron
Copy link
Contributor

This fell off my radar while helping out implement DMs. Merging now so we should be 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make compose textarea automatically grow when you have entered a lot of text
4 participants