-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] prevent OpenReport api call with "null" report #28560
Conversation
Reviewer Checklist
Screenshots/VideosWebCleanShot.2023-10-01.at.14.30.15.mp4Mobile Web - ChromeCleanShot.2023-10-01.at.14.46.41.mp4Mobile Web - SafariCleanShot.2023-10-01.at.14.45.51.mp4DesktopCleanShot.2023-10-01.at.14.50.55.mp4iOSCleanShot.2023-10-01.at.14.42.26.mp4AndroidCleanShot.2023-10-01.at.16.10.52.mp4 |
@mkhutornyi Can you please update QA steps to match issue steps?
|
Sure. But hard to reproduce with this simple step. Only with HT account, very slow connection. |
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkhutornyi Could we update it as such, I think its misleading to say it should be string because reportIDs should be numbers in the App so lets clarify it is the reportIDFromPath
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
@mkhutornyi you still need to update the export and use of the method |
Addressing feedback now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] prevent OpenReport api call with "null" report (cherry picked from commit 5865e08)
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.75-12 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.75-12 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
Fixed Issues
$ #28504
PROPOSAL: #28504 (comment)
Tests
Same as QA step
Offline tests
Same as QA step
QA Steps
Case 1:
(slow network connection is preferred)
Case 2:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mchrome.mov
Mobile Web - Safari
msafari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov