-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update appropriate message for legal name validation. #28892
Conversation
@ntdiary PR is ready! |
@hungvu193, yeah, we have more relaxed rules for display name. Also, can you please verify the translation in Slack? |
Sure. Posted here |
No update yet, can you complete the checklist so we can get the urgency bonus? @ntdiary |
Reviewer Checklist
Screenshots/VideosWeb28892-web.mp4Mobile Web - Chrome28892-mobile-chrome.mp4Mobile Web - Safari28892-mobile-safari.mp4Desktop28892-desktop.mp4iOS28892-mobile-ios.mp4Android28892-mobile-android.mp4 |
Ideally, we need to confirm first that the text is approved by marketing. Let's wait a few more hours first. : ) |
Cool, we're all go to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For referring to the Latin alphabet or Latin script, the capitalized form "Latin" is more commonly used in English.
Some examples:
- "The Latin alphabet is used to write many European and Western languages."
- "Many Latin letters like A, B, and C originate from the Phoenician alphabet."
- "Latin script includes letters, numbers, punctuation marks, and other symbols."
Using the lowercase "latin" is not really incorrect, but it would be seen as less formal. The capitalized term "Latin" is preferred, especially in more academic, scientific, or technical content about languages and scripts.
So in summary, for referring to the Latin alphabet/script or Latin letters, "Latin" is the standard and most widely accepted term in English. Using "Latin" with a capital L is recommended over "latin" in most cases.
I'm still not too familiar with English, but based on Claude's reply, it's fine to use Latin
(capitalized) here. : )
cc @NikkiWines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor copy adjustment sorry
src/languages/en.ts
Outdated
@@ -985,7 +985,7 @@ export default { | |||
error: { | |||
dateShouldBeBefore: ({dateString}: DateShouldBeBeforeParams) => `Date should be before ${dateString}.`, | |||
dateShouldBeAfter: ({dateString}: DateShouldBeAfterParams) => `Date should be after ${dateString}.`, | |||
hasInvalidCharacter: 'Name can only include letters.', | |||
hasInvalidCharacter: 'Name can only include Latin letters.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latin characters
makes more sense, I think. And en espanol this would be caracteres latinos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikkiWines so the Spanish will be El nombre sólo puede incluir caracteres latinos.
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Updated already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.81-0 🚀
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.83-0 🚀
|
Details
#28250
Fixed Issues
$ #28250
PROPOSAL: #28250 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-10-05.at.14.09.24.mov
Mobile Web - Chrome
Mobile Web - Safari
Screen.Recording.2023-10-05.at.14.28.59.mov
Desktop
Screen.Recording.2023-10-05.at.14.11.16.mov
iOS
Screen.Recording.2023-10-05.at.14.28.06.mov
Android
Screen.Recording.2023-10-05.at.14.49.29.mov