General cleanup on stylesheet #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnborton
reviewed
Aug 27, 2020
src/style/StyleSheet.js
Outdated
| @@ -523,7 +527,7 @@ const styles = { | |||
| bottom: 0, | |||
| zIndex: 2, | |||
| width: 300, | |||
| shadowColor: '#000000', | |||
| shadowColor: colors.shadow, | |||
There was a problem hiding this comment.
I think this is okay for now, but I wonder if we might just want this to be colors.black or something, and then at some point we might have a standard shadow which we could extend that would have the correct color/offset/opacity/radius values.
|
Updated to rename to black 👍 |
shawnborton
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shawnborton these were just a few things I noticed where it would be better to use variables.
Tests
You know... it would be really easy at this point to use two different
colorobjects depending on the time of day (hint: day mode and night mode)