-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'Banner.js' component to TypeScript #31496
[TS migration] Migrate 'Banner.js' component to TypeScript #31496
Conversation
</Text> | ||
)} | ||
</View> | ||
{props.shouldShowCloseButton && ( | ||
<Tooltip text={props.translate('common.close')}> | ||
{shouldShowCloseButton && !!onClose && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably create a regression here as onClose
/onPress
props are optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioh8010 Since onClose
is passed together with shouldShowCloseButton
, and in your example shouldShowCloseButton
isn't passed and will be false
by default, I think it should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Fine with this change but after this change, I am not sure about the need of shouldShowCloseButton
prop. onClose
prop should be enough.
</Text> | ||
)} | ||
</View> | ||
{props.shouldShowCloseButton && ( | ||
<Tooltip text={props.translate('common.close')}> | ||
{shouldShowCloseButton && !!onClose && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I am getting this error while running storybook. Anyone can help? Edit: fixed by installing |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movstorybook.movMacOS: Desktopdesktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25088 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some places we use .ts
and other .tsx
extension, does it matter which one is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bondydaa Yeah, we use .tsx
extension when a file has JSX syntax (components for example), otherwise it's just .ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah makes sense 🤦
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.3-0 🚀
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.3-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.3-11 🚀
|
Details
[TS migration] Migrate 'Banner.js' component to TypeScript
Fixed Issues
$ #25088
PROPOSAL: N/A
Tests
Storybook:
App:
Offline tests
N/A
QA Steps
Storybook:
App:
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Storybook