Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector #32665

Merged
merged 54 commits into from
Jan 26, 2024
Merged

Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector #32665

merged 54 commits into from
Jan 26, 2024

Commits on Dec 7, 2023

  1. Add 'didScreenTransitionEnd' prop to MoneyRequestParticipantsSelector

    @brunovjk
    brunovjk committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9eafd1f View commit details
    Browse the repository at this point in the history

  2. Integrate 'didScreenTransitionEnd' prop in MoneyRequestParticipantsPage

    @brunovjk
    brunovjk committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a5ed7d8 View commit details
    Browse the repository at this point in the history

  3. Conditionally update chatOptions on screen transition end

    @brunovjk
    brunovjk committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    19d6d68 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    55d9a41 View commit details
    Browse the repository at this point in the history

  2. Revert "Conditionally update chatOptions on screen 

    transition end"

This reverts commit 19d6d68.
    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ef06c1f View commit details
    Browse the repository at this point in the history

  3. Revert "Integrate 'didScreenTransitionEnd' prop in MoneyRequestPartic… 

    …ipantsPage"

This reverts commit a5ed7d8.
    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1108784 View commit details
    Browse the repository at this point in the history

  4. Revert "Add 'didScreenTransitionEnd' prop to MoneyRequestParticipants… 

    …Selector"

This reverts commit 9eafd1f.
    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c69ecfd View commit details
    Browse the repository at this point in the history

  5. Integrate 'didScreenTransitionEnd' prop in IOURequestStepParticipants

    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    dc1f87f View commit details
    Browse the repository at this point in the history

  6. Add 'didScreenTransitionEnd' prop to MoneyRequestParticipantsSelector

    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9cd0ab5 View commit details
    Browse the repository at this point in the history

  7. Conditionally update 'chatOptions' on screen transition end

    @brunovjk
    brunovjk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    a6a36f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Use early return

    @brunovjk
    brunovjk committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    cb61682 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    7ab9d2e View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a1b01da View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Enhance 'OptionsListSkeletonView' for quicker display using Dimensions.

    @brunovjk
    brunovjk committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    4f25fa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2023

  1. Revert "Enhance 'OptionsListSkeletonView' for quicker display using D… 

    …imensions."

This reverts commit 4f25fa7.
    @brunovjk
    brunovjk committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    fefd084 View commit details
    Browse the repository at this point in the history

  2. Optimize OptionsListSkeletonView component

    @brunovjk
    brunovjk committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    271ace6 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    029fa85 View commit details
    Browse the repository at this point in the history

  2. Revert "Optimize OptionsListSkeletonView component" 

    This reverts commit 271ace6.
    @brunovjk
    brunovjk committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    99dd07a View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Dec 29, 2023
    Configuration menu
    Copy the full SHA
    3986a81 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 5, 2024
    Configuration menu
    Copy the full SHA
    2270062 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bfb12bb View commit details
    Browse the repository at this point in the history

  2. Move 'isOptionsDataReady' to an 'useState'

    @brunovjk
    brunovjk committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ed2ffb4 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Merge branch 'main' into fix/31779

    @brunovjk
    brunovjk authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    475fff1 View commit details
    Browse the repository at this point in the history

  2. Pass 'didScreenTransitionEnd' from 'StepParticipants.StepScreenWrappe… 

    …r' to 'ParticipantsSelector'
    @brunovjk
    brunovjk committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    37dc816 View commit details
    Browse the repository at this point in the history

  3. Handle OptionsListUtils logic after screen transition

    @brunovjk
    brunovjk committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    8af2b8d View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Implement 'isLoadingNewOptions' to 'BaseSelectionList'

    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a2611cc View commit details
    Browse the repository at this point in the history

  2. Adjust 'SelectionList' props

    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    301df39 View commit details
    Browse the repository at this point in the history

  3. Fill MoneyRequestReferralProgramCTA icon

    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6d15a87 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    82c8354 View commit details
    Browse the repository at this point in the history

  5. Revert "Fill MoneyRequestReferralProgramCTA icon" 

    This reverts commit 6d15a87.
    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    078b4ce View commit details
    Browse the repository at this point in the history

  6. Use debounce text input value

    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    87f5cf5 View commit details
    Browse the repository at this point in the history

  7. applying all the same changes in 'pages/iou/steps/MoneyRequstParticip… 

    …antsPage/MoneyRequestParticipantsSelector.js'
    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    97f1c9a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix/31779

    @brunovjk
    brunovjk authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    23762b2 View commit details
    Browse the repository at this point in the history

  9. Resolve conflict over 'ReferralProgramCTA'

    @brunovjk
    brunovjk committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    8d08f71 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2ecf126 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d0c8b4a View commit details
    Browse the repository at this point in the history

  2. Changes requested by reviewer

    @brunovjk
    brunovjk committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8859d21 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/31779

    @brunovjk
    brunovjk committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2bb870a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5948764 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1b98d99 View commit details
    Browse the repository at this point in the history

  2. Revert Migrate 'SelectionList'

    @brunovjk
    brunovjk committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7f01b8d View commit details
    Browse the repository at this point in the history

  3. Resolve conflict over Migrate 'SelectionList'

    @brunovjk
    brunovjk committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    1a94efa View commit details
    Browse the repository at this point in the history

  4. Resolve conflict over Migrate 'SelectionList'

    @brunovjk
    brunovjk committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    0d6b7a5 View commit details
    Browse the repository at this point in the history

  5. Run prettier

    @brunovjk
    brunovjk committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8c0eee2 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e9184c0 View commit details
    Browse the repository at this point in the history

  2. Isolate reuse 'didScreenTransitionEnd' to address the screen transiti… 

    …on skeleton issue
    @brunovjk
    brunovjk committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    5540838 View commit details
    Browse the repository at this point in the history

  3. remove redundance

    @brunovjk
    brunovjk committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c235a06 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d8df1ee View commit details
    Browse the repository at this point in the history

  2. fix lint

    @brunovjk
    brunovjk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a5caca2 View commit details
    Browse the repository at this point in the history

  3. fix lint: Removed unused variables and props

    @brunovjk
    brunovjk committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c53276d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1ca1e51 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    30d53b6 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    536bb07 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'Expensify:main' into fix/31779

    @brunovjk
    brunovjk authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6c649a3 View commit details
    Browse the repository at this point in the history