Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract gesture logic from MultiGestureCanvas to hooks and improve code #33756

Merged

Commits on Dec 14, 2023

  1. start migration

    chrispader committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    15b35b3 View commit details
    Browse the repository at this point in the history
  2. continue

    chrispader committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    83df849 View commit details
    Browse the repository at this point in the history
  3. further type stuff

    chrispader committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    3a8a606 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. fix: better gestures

    Christoph Pader committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1da2e9a View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. further improve variable names

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    3d1691d View commit details
    Browse the repository at this point in the history
  2. extract gesture code to hooks

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    4c0d2c5 View commit details
    Browse the repository at this point in the history
  3. further simplify

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    2632f75 View commit details
    Browse the repository at this point in the history
  4. improve styles in Lightbox

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1413871 View commit details
    Browse the repository at this point in the history
  5. rename "isScrolling" prop

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    dae44fc View commit details
    Browse the repository at this point in the history
  6. add more docs

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    7bcf3f5 View commit details
    Browse the repository at this point in the history
  7. further improve component

    Christoph Pader committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    a08e2bb View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. add and improve comments

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8755916 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e7fe03 View commit details
    Browse the repository at this point in the history
  3. remove unused props

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    70bd5b7 View commit details
    Browse the repository at this point in the history
  4. rename variable

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f95f9c6 View commit details
    Browse the repository at this point in the history
  5. simplify pinch gesture

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    610f59f View commit details
    Browse the repository at this point in the history
  6. fix: variable names

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    730a998 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0b20554 View commit details
    Browse the repository at this point in the history
  8. rename variables

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    9483b8f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    16f2497 View commit details
    Browse the repository at this point in the history
  10. improve pan gesture code

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ba75ac9 View commit details
    Browse the repository at this point in the history
  11. fix: pinch gesture

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    1de9b25 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3d93b5e View commit details
    Browse the repository at this point in the history
  13. improve pan gesture code

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    f0c542b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    58fe25b View commit details
    Browse the repository at this point in the history
  15. improve comments

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    60b6404 View commit details
    Browse the repository at this point in the history
  16. add more comments

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b1b592a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    55c2662 View commit details
    Browse the repository at this point in the history
  18. fix: types

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4b48f28 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    103e1b2 View commit details
    Browse the repository at this point in the history
  20. fix: eslint

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8856caf View commit details
    Browse the repository at this point in the history
  21. fix: eslint

    chrispader committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b6bbdec View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    330c1a8 View commit details
    Browse the repository at this point in the history
  2. remove pager ref

    chrispader committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f8445e4 View commit details
    Browse the repository at this point in the history
  3. update comments

    Christoph Pader committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    937b4b1 View commit details
    Browse the repository at this point in the history
  4. improve lightbox styles

    Christoph Pader committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7e148ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da5dca5 View commit details
    Browse the repository at this point in the history
  6. remove onPinchGestureChange callback

    Christoph Pader committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    9b6c8fe View commit details
    Browse the repository at this point in the history
  7. fix: carousel arrows

    Christoph Pader committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    351eb53 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    fe9f43b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    91b1e17 View commit details
    Browse the repository at this point in the history
  3. Merge branch '@chrispader/restructure-multi-gesture-canvas' into @chr…

    …ispader/attachment-gallery-ts-migration
    chrispader committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    39bcb22 View commit details
    Browse the repository at this point in the history
  4. migrate hooks

    chrispader committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    fcfa059 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Configuration menu
    Copy the full SHA
    2b1793a View commit details
    Browse the repository at this point in the history
  2. move types

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    945fd35 View commit details
    Browse the repository at this point in the history
  3. migrate Lightbox

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    369d61d View commit details
    Browse the repository at this point in the history
  4. restructure

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    d209ac2 View commit details
    Browse the repository at this point in the history
  5. add back propTypes

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    24d34a5 View commit details
    Browse the repository at this point in the history
  6. simplify props

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    083f37c View commit details
    Browse the repository at this point in the history
  7. improve Lightbox

    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5953370 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8715d7c View commit details
    Browse the repository at this point in the history
  9. Merge branch '@chrispader/restructure-multi-gesture-canvas' into @chr…

    …ispader/attachment-gallery-ts-migration
    chrispader committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    818f797 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9c393c4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d55844b View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. remove comment

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    616e8cb View commit details
    Browse the repository at this point in the history
  2. update error supression

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3055579 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1f6db1e View commit details
    Browse the repository at this point in the history
  4. revert Lightbox changes

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0b741dd View commit details
    Browse the repository at this point in the history
  5. fix: revert changes

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9429921 View commit details
    Browse the repository at this point in the history
  6. fix: hook deps

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a869e63 View commit details
    Browse the repository at this point in the history
  7. more fixes

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b42422b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7214c92 View commit details
    Browse the repository at this point in the history
  9. update propTypes

    Christoph Pader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b10e600 View commit details
    Browse the repository at this point in the history
  10. fix: import

    chrispader committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f1a6f9b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    22ce23e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f9ae229 View commit details
    Browse the repository at this point in the history
  3. Merge branch '@chrispader/attachment-gallery-ts-migration' into @chri…

    …spader/restructure-multi-gesture-canvas
    chrispader committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a003b32 View commit details
    Browse the repository at this point in the history
  4. remove propTypes

    chrispader committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    95b2e84 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Update src/components/MultiGestureCanvas/useTapGestures.ts

    Co-authored-by: Błażej Kustra <46095609+blazejkustra@users.noreply.github.com>
    chrispader and blazejkustra authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b21c8a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6651977 View commit details
    Browse the repository at this point in the history
  3. address GH comments

    chrispader committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e944dc2 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Configuration menu
    Copy the full SHA
    ac5dff2 View commit details
    Browse the repository at this point in the history
  2. improve and clean up PR

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    905ba17 View commit details
    Browse the repository at this point in the history
  3. more improvements

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    71135aa View commit details
    Browse the repository at this point in the history
  4. rename context type

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    397c1aa View commit details
    Browse the repository at this point in the history
  5. further address comments

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    993afa8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    74343c5 View commit details
    Browse the repository at this point in the history
  7. fix: arrow buttons

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    27aeea9 View commit details
    Browse the repository at this point in the history
  8. fix: pager not swiping

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6d92147 View commit details
    Browse the repository at this point in the history
  9. remove undefined

    chrispader committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    710a3fb View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    c338116 View commit details
    Browse the repository at this point in the history
  2. fix: problems

    chrispader committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5d8799f View commit details
    Browse the repository at this point in the history
  3. fix: arrows not showable

    chrispader committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c06219a View commit details
    Browse the repository at this point in the history
  4. fix: callback deps

    chrispader committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    19350f9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    05ade3c View commit details
    Browse the repository at this point in the history
  2. fix: callback prop

    chrispader committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    fcee0f2 View commit details
    Browse the repository at this point in the history
  3. move style

    chrispader committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    395e25c View commit details
    Browse the repository at this point in the history
  4. memoize style

    chrispader committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8164ff5 View commit details
    Browse the repository at this point in the history
  5. fix: wrong condition

    chrispader committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5cba6a8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ef114a0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e90de14 View commit details
    Browse the repository at this point in the history
  8. improve style memo

    chrispader committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    773b4dc View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    5a988f6 View commit details
    Browse the repository at this point in the history
  2. fix: arrows in pdf delayed

    chrispader committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b61949d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1049b84 View commit details
    Browse the repository at this point in the history
  4. fix: lightbox flashing

    chrispader committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    5221cff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2dc798d View commit details
    Browse the repository at this point in the history
  6. add comment

    chrispader committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    08a6c41 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    0c0e157 View commit details
    Browse the repository at this point in the history
  2. improve

    Christoph Pader committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    0446a6d View commit details
    Browse the repository at this point in the history
  3. improve types

    Christoph Pader committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    acadc33 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    e07475e View commit details
    Browse the repository at this point in the history
  2. fix: pdf scroll

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    6d21d62 View commit details
    Browse the repository at this point in the history
  3. fix: worklet error

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c8770bb View commit details
    Browse the repository at this point in the history
  4. improve pdf

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    f3b7de5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c3d1443 View commit details
    Browse the repository at this point in the history
  6. remove unused prop

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cc5bb33 View commit details
    Browse the repository at this point in the history
  7. fix: console errors

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4b8f183 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7db6a92 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7e1e2b3 View commit details
    Browse the repository at this point in the history
  10. remove redundant isScrollEnabled change

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4d00c87 View commit details
    Browse the repository at this point in the history
  11. remove round function

    Christoph Pader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    5f17f2b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5ad1817 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    80bf0ad View commit details
    Browse the repository at this point in the history
  14. remove unusedProp

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a83a16e View commit details
    Browse the repository at this point in the history
  15. fix: onScaleChanged prop

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    aff821c View commit details
    Browse the repository at this point in the history
  16. fix: prop types

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    1ea4d70 View commit details
    Browse the repository at this point in the history
  17. fix: pager

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8c6cb24 View commit details
    Browse the repository at this point in the history
  18. fix: wrong condition

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d8d4a29 View commit details
    Browse the repository at this point in the history
  19. improve readability

    chrispader committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    bb91b85 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. fix: state setter

    chrispader committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f54a4b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fce6a6f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a254de View commit details
    Browse the repository at this point in the history
  4. fix: loading issues

    chrispader committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2a2f007 View commit details
    Browse the repository at this point in the history
  5. remove unused code

    chrispader committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    33dea64 View commit details
    Browse the repository at this point in the history
  6. simplify condition

    chrispader committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a058e3b View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    8fec0d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    49a6469 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7bc6f98 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    3a7b24c View commit details
    Browse the repository at this point in the history
  2. add comment

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    57d1f7e View commit details
    Browse the repository at this point in the history
  3. remove empty line?

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1594b72 View commit details
    Browse the repository at this point in the history
  4. add comment

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d6da8e9 View commit details
    Browse the repository at this point in the history
  5. add comment

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f2e4057 View commit details
    Browse the repository at this point in the history
  6. simplify usePageScrollHandler

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3817512 View commit details
    Browse the repository at this point in the history
  7. rename type

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    6aae70b View commit details
    Browse the repository at this point in the history
  8. add cp,,emt

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    62c1d4f View commit details
    Browse the repository at this point in the history
  9. improve

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2d5eb62 View commit details
    Browse the repository at this point in the history
  10. remove empty line

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4eaad5a View commit details
    Browse the repository at this point in the history
  11. rename variable

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9a5a833 View commit details
    Browse the repository at this point in the history
  12. add comment

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    55d36a6 View commit details
    Browse the repository at this point in the history
  13. add comment

    Christoph Pader committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9a53061 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    718acf0 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    8ddbf36 View commit details
    Browse the repository at this point in the history