Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default category for distance request #34012

Merged
merged 9 commits into from
Feb 6, 2024
Merged

Set default category for distance request #34012

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d9d193
set default category for distance request
tienifr Jan 5, 2024
62f1fb1
use lodashGet instead
tienifr Jan 5, 2024
9eb8901
Merge branch 'main' of https://github.com/tienifr/App into fix/33388
tienifr Jan 18, 2024
556b831
set default category only when unset
tienifr Jan 18, 2024
663671a
Merge branch 'main' of https://github.com/tienifr/App into fix/33388
tienifr Jan 22, 2024
c7925f5
fix lint
tienifr Jan 22, 2024
1296790
set default category for distance request only
tienifr Feb 2, 2024
63d2dfc
Merge branch 'main' of https://github.com/tienifr/App into fix/33388
tienifr Feb 2, 2024
cbbc7a3
fix lint
tienifr Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/pages/iou/request/step/IOURequestStepConfirmation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,15 @@ function IOURequestStepConfirmation({
IOU.setMoneyRequestBillable_temporaryForRefactor(transactionID, defaultBillable);
}, [transactionID, defaultBillable]);

const defaultCategory = lodashGet(
_.find(lodashGet(policy, 'customUnits', {}), (customUnit) => customUnit.name === CONST.CUSTOM_UNITS.NAME_DISTANCE),
'defaultCategory',
'',
);
useEffect(() => {
IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This always resets category to default one while in money request flow.
This should be happen only when unset

Screen.Recording.2024-01-18.at.10.49.15.PM.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

}, [transactionID, defaultCategory]);

const navigateBack = useCallback(() => {
// If there is not a report attached to the IOU with a reportID, then the participants were manually selected and the user needs taken
// back to the participants step
Expand Down
Loading