[TS migration] Migrate 'MoneyRequestConfirmationList.js' component to TypeScript

src/ONYXKEYS.ts

@@ -437,8 +437,9 @@ type OnyxValues = {
     [ONYXKEYS.COLLECTION.DOWNLOAD]: OnyxTypes.Download;
     [ONYXKEYS.COLLECTION.POLICY]: OnyxTypes.Policy;
     [ONYXKEYS.COLLECTION.POLICY_DRAFTS]: OnyxTypes.Policy;
-    [ONYXKEYS.COLLECTION.POLICY_CATEGORIES]: OnyxTypes.PolicyCategory;
+    [ONYXKEYS.COLLECTION.POLICY_CATEGORIES]: OnyxTypes.PolicyCategories;
     [ONYXKEYS.COLLECTION.POLICY_TAGS]: OnyxTypes.PolicyTags;
+    [ONYXKEYS.COLLECTION.POLICY_TAX_RATE]: OnyxTypes.PolicyTaxRate;
     [ONYXKEYS.COLLECTION.POLICY_MEMBERS]: OnyxTypes.PolicyMembers;
     [ONYXKEYS.COLLECTION.POLICY_MEMBERS_DRAFTS]: OnyxTypes.PolicyMember;
     [ONYXKEYS.COLLECTION.POLICY_RECENTLY_USED_CATEGORIES]: OnyxTypes.RecentlyUsedCategories;

src/components/MenuItem.tsx

@@ -204,7 +204,7 @@ type MenuItemProps = (IconProps | AvatarProps | NoIcon) & {
     shouldBlockSelection?: boolean;
 
     /** Whether should render title as HTML or as Text */
-    shouldParseTitle?: false;
+    shouldParseTitle?: boolean;
 
     /** Should check anonymous user in onPress function */
     shouldCheckActionAllowedOnPress?: boolean;

src/libs/ReceiptUtils.ts

@@ -1,5 +1,6 @@
 import Str from 'expensify-common/lib/str';
 import type {ImageSourcePropType} from 'react-native';
+import type {OnyxEntry} from 'react-native-onyx';
 import ReceiptDoc from '@assets/images/receipt-doc.png';
 import ReceiptGeneric from '@assets/images/receipt-generic.png';
 import ReceiptHTML from '@assets/images/receipt-html.png';
@@ -28,7 +29,7 @@ type FileNameAndExtension = {
  * @param receiptPath
  * @param receiptFileName
  */
-function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string | null = null, receiptFileName: string | null = null): ThumbnailAndImageURI {
+function getThumbnailAndImageURIs(transaction: OnyxEntry<Transaction>, receiptPath: string | null = null, receiptFileName: string | null = null): ThumbnailAndImageURI {
     // URI to image, i.e. blob:new.expensify.com/9ef3a018-4067-47c6-b29f-5f1bd35f213d or expensify.com/receipts/w_e616108497ef940b7210ec6beb5a462d01a878f4.jpg
     const path = transaction?.receipt?.source ?? receiptPath ?? '';
     // filename of uploaded image or last part of remote URI
@@ -39,7 +40,7 @@ function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string
 
     if (!Object.hasOwn(transaction?.pendingFields ?? {}, 'waypoints')) {
         if (hasEReceipt) {
-            return {thumbnail: null, image: ROUTES.ERECEIPT.getRoute(transaction.transactionID), transaction};
+            return {thumbnail: null, image: ROUTES.ERECEIPT.getRoute(transaction?.transactionID), transaction};
         }
 
         // For local files, we won't have a thumbnail yet

src/libs/ReportUtils.ts

@@ -76,6 +76,7 @@ type Participant = {
     searchText: string;
     selected: boolean;
     text: string;
+    descriptiveText?: string;
 };
 
 type SpendBreakdown = {
@@ -4536,4 +4537,4 @@ export {
     shouldDisableThread,
 };
 
-export type {ExpenseOriginalMessage, OptionData, OptimisticChatReport, OptimisticCreatedReportAction};
+export type {ExpenseOriginalMessage, OptionData, OptimisticChatReport, OptimisticCreatedReportAction, Participant};

src/libs/TransactionUtils.ts

@@ -139,23 +139,24 @@ function hasReceipt(transaction: Transaction | undefined | null): boolean {
     return !!transaction?.receipt?.state || hasEReceipt(transaction);
 }
 
-function isMerchantMissing(transaction: Transaction) {
-    const isMerchantEmpty = transaction.merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT || transaction.merchant === '';
+function isMerchantMissing(transaction: OnyxEntry<Transaction>) {
+    const isMerchantEmpty = transaction?.merchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT || transaction?.merchant === '';
 
-    const isModifiedMerchantEmpty = !transaction.modifiedMerchant || transaction.modifiedMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT || transaction.modifiedMerchant === '';
+    const isModifiedMerchantEmpty =
+        !transaction?.modifiedMerchant || transaction?.modifiedMerchant === CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT || transaction?.modifiedMerchant === '';
 
     return isMerchantEmpty && isModifiedMerchantEmpty;
 }
 
-function isAmountMissing(transaction: Transaction) {
-    return transaction.amount === 0 && (!transaction.modifiedAmount || transaction.modifiedAmount === 0);
+function isAmountMissing(transaction: OnyxEntry<Transaction>) {
+    return transaction?.amount === 0 && (!transaction?.modifiedAmount || transaction?.modifiedAmount === 0);
 }
 
-function isCreatedMissing(transaction: Transaction) {
-    return transaction.created === '' && (!transaction.created || transaction.modifiedCreated === '');
+function isCreatedMissing(transaction: OnyxEntry<Transaction>) {
+    return transaction?.created === '' && (!transaction?.created || transaction?.modifiedCreated === '');
 }
 
-function areRequiredFieldsEmpty(transaction: Transaction): boolean {
+function areRequiredFieldsEmpty(transaction: OnyxEntry<Transaction>): boolean {
     const parentReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`] ?? null;
     const isFromExpenseReport = parentReport?.type === CONST.REPORT.TYPE.EXPENSE;
     return (isFromExpenseReport && isMerchantMissing(transaction)) || isAmountMissing(transaction) || isCreatedMissing(transaction);
@@ -434,7 +435,7 @@ function hasMissingSmartscanFields(transaction: OnyxEntry<Transaction>): boolean
 /**
  * Check if the transaction has a defined route
  */
-function hasRoute(transaction: Transaction): boolean {
+function hasRoute(transaction: OnyxEntry<Transaction>): boolean {
     return !!transaction?.routes?.route0?.geometry?.coordinates;
 }
 

src/types/onyx/Policy.ts

@@ -10,6 +10,12 @@ type Rate = {
     currency: string;
 };
 
+type MileageRate = {
+    unit: Unit;
+    rate: number;
+    currency: string;
+};
+
 type CustomUnit = {
     customUnitID?: string;
     name?: string;
@@ -82,8 +88,17 @@ type Policy = {
 
     /** The employee list of the policy */
     employeeList?: [];
+
+    /** Whether tax tracking enabled for policy */
+    isTaxTrackingEnabled?: boolean;
+
+    disabledFields?: Record<string, boolean>;
+
+    requiresCategory?: boolean;
+
+    requiresTag?: boolean;
 };
 
 export default Policy;
 
-export type {Unit};
+export type {Unit, MileageRate};

src/types/onyx/PolicyTag.ts

@@ -8,6 +8,7 @@ type PolicyTag = {
     /** "General Ledger code" that corresponds to this tag in an accounting system. Similar to an ID. */
     // eslint-disable-next-line @typescript-eslint/naming-convention
     'GL Code': string;
+    tags: PolicyTags;
 };
 
 type PolicyTags = Record<string, PolicyTag>;

src/types/onyx/PolicyTaxRates.ts

@@ -7,6 +7,10 @@ type PolicyTaxRate = {
 
     /** Whether the tax is disabled */
     isDisabled?: boolean;
+
+    defaultExternalID: string;
+
+    taxes: PolicyTaxRates;
 };
 
 type PolicyTaxRates = Record<string, PolicyTaxRate>;

src/types/onyx/Transaction.ts

@@ -3,6 +3,15 @@ import type CONST from '@src/CONST';
 import type * as OnyxCommon from './OnyxCommon';
 import type RecentWaypoint from './RecentWaypoint';
 
+type TaxRate = {
+    text: string;
+    keyForList: string;
+    data: {
+        value: string;
+    };
+    modifiedName?: string;
+};
+
 type Waypoint = {
     /** The name associated with the address of the waypoint */
     name?: string;
@@ -18,6 +27,7 @@ type Waypoint = {
 };
 
 type WaypointCollection = Record<string, RecentWaypoint | Waypoint>;
+
 type Comment = {
     comment?: string;
     waypoints?: WaypointCollection;
@@ -94,6 +104,8 @@ type Transaction = {
     /** If the transaction was made in a foreign currency, we send the original amount and currency */
     originalAmount?: number;
     originalCurrency?: string;
+    taxAmount?: number;
+    taxRate?: TaxRate;
 };
 
 export default Transaction;

src/types/onyx/index.ts

@@ -32,6 +32,8 @@ import type {PolicyMembers} from './PolicyMember';
 import type PolicyMember from './PolicyMember';
 import type PolicyReportField from './PolicyReportField';
 import type {PolicyTag, PolicyTags} from './PolicyTag';
+import type {PolicyTaxRates} from './PolicyTaxRates';
+import type PolicyTaxRate from './PolicyTaxRates';
 import type PrivatePersonalDetails from './PrivatePersonalDetails';
 import type RecentlyUsedCategories from './RecentlyUsedCategories';
 import type RecentlyUsedReportFields from './RecentlyUsedReportFields';
@@ -139,4 +141,6 @@ export type {
     ReportUserIsTyping,
     PolicyReportField,
     RecentlyUsedReportFields,
+    PolicyTaxRate,
+    PolicyTaxRates,
 };