Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use error prop for violations for consistent styling #34303

Merged
merged 41 commits into from
Feb 13, 2024
Merged

Use error prop for violations for consistent styling #34303

merged 41 commits into from
Feb 13, 2024

Commits on Jan 10, 2024

  1. feat(Violations): create useMoneyRequestViewErrors and move violation… 

    …s into errors prop of inputs
    @trevor-coleman
    trevor-coleman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a4844ce View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    67b0987 View commit details
    Browse the repository at this point in the history

  3. feat(Violations): move hasViolations into useMoneyRequestViewErrors, … 

    …and update brickRoadIndicatorProps
    @trevor-coleman
    trevor-coleman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6dc9f5c View commit details
    Browse the repository at this point in the history

  4. feat(Violations): add comment

    @trevor-coleman
    trevor-coleman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    36b7dbf View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. feat(Violations): add comment

    @trevor-coleman
    trevor-coleman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    02fe40d View commit details
    Browse the repository at this point in the history

  2. feat(Violations): move getErrorForField into MoneyRequestView

    @trevor-coleman
    trevor-coleman committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    d3fecfc View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Merge branch 'cdanwards/violations/transaction-thread-violations' int… 

    …o 32594-update-style-for-violations
    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    c19d1a8 View commit details
    Browse the repository at this point in the history

  2. feat(Violations): fix import

    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    e12dc9f View commit details
    Browse the repository at this point in the history

  3. feat(Violations): update translation params to match violation data o… 

    …bject
    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    32efefc View commit details
    Browse the repository at this point in the history

  4. feat(Violations): change param names to match violation data prop

    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    70e45a8 View commit details
    Browse the repository at this point in the history

  5. feat(Violations): change param names to match violation data prop

    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    df51b44 View commit details
    Browse the repository at this point in the history

  6. feat(Violations): fixes

    @trevor-coleman
    trevor-coleman committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    394caca View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/components/ReportActionItem/MoneyRequestView.js
#	src/libs/ReportUtils.ts
#	src/libs/SidebarUtils.ts
#	src/pages/home/sidebar/SidebarLinksData.js
    @trevor-coleman
    trevor-coleman committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    b8b7b18 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. feat(Violations): filter violations by type

    @trevor-coleman
    trevor-coleman committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    2a624f9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/libs/ReportUtils.ts
#	src/libs/SidebarUtils.ts
    @trevor-coleman
    trevor-coleman committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b80bcdd View commit details
    Browse the repository at this point in the history

  3. feat(Violations): fix dependency array

    @trevor-coleman
    trevor-coleman committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e37a63a View commit details
    Browse the repository at this point in the history

  4. feat(Violations): handle default case for missing tag

    @trevor-coleman
    trevor-coleman committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ef959ef View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    cd807d6 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. feat(Violations): simplify

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    8be0e64 View commit details
    Browse the repository at this point in the history

  2. feat(Violations): fix fields

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    0adddd0 View commit details
    Browse the repository at this point in the history

  3. feat(Violations): reword comment

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a336be8 View commit details
    Browse the repository at this point in the history

  4. feat(Violations): remove redundant check

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    01c552c View commit details
    Browse the repository at this point in the history

  5. feat(Violations): add space

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    498634a View commit details
    Browse the repository at this point in the history

  6. feat(Violations): change empty string to single quotes

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    015764e View commit details
    Browse the repository at this point in the history

  7. feat(Violations): make translations consistent

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b2ba0b6 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/languages/es.ts
    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3a75337 View commit details
    Browse the repository at this point in the history

  9. feat(Violations): rename vars

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    581f8b0 View commit details
    Browse the repository at this point in the history

  10. feat(Violations): return empty string if variables are missing

    @trevor-coleman
    trevor-coleman committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    c92ee98 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a556d5f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c9e75c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    9cdf6ea View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/components/ReportActionItem/MoneyRequestView.tsx
    @trevor-coleman
    trevor-coleman committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    a828529 View commit details
    Browse the repository at this point in the history

  2. feat(Violations): restore type

    @trevor-coleman
    trevor-coleman committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    abf3255 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/components/ReportActionItem/MoneyRequestView.tsx
    @trevor-coleman
    trevor-coleman committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    5498c82 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge remote-tracking branch 'origin/main' into 32594-update-style-fo… 

    …r-violations

# Conflicts:
#	src/libs/Violations/ViolationsUtils.ts
    @trevor-coleman
    trevor-coleman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e90cf9f View commit details
    Browse the repository at this point in the history

  2. feat(Violations): add deps to array

    @trevor-coleman
    trevor-coleman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    011a08a View commit details
    Browse the repository at this point in the history

  3. feat(Violations): replace tag field

    @trevor-coleman
    trevor-coleman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    519897a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2327c7c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    df76a09 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations
    @trevor-coleman
    trevor-coleman committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7eb9560 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into 32594-update-style-… 

    …for-violations

# Conflicts:
#	src/components/ReportActionItem/MoneyRequestView.tsx
    @trevor-coleman
    trevor-coleman committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    766ccf3 View commit details
    Browse the repository at this point in the history