Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement useArrowKeyFocusManager in EmojiPickerMenu #34581

Merged
merged 21 commits into from
Feb 1, 2024
Merged

feat: implement useArrowKeyFocusManager in EmojiPickerMenu #34581

merged 21 commits into from
Feb 1, 2024

Commits on Jan 22, 2024

  1. add left and right arrow support in useArrowKeyFocusManager

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9fcd8ed View commit details
    Browse the repository at this point in the history

  2. update useArrowKeyFocusManager down & up behavior

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b2f6d98 View commit details
    Browse the repository at this point in the history

  3. add arrow key to hook

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    718b67b View commit details
    Browse the repository at this point in the history

  4. update useArrowKeyFocusManager to correctly find next index

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fcc45b8 View commit details
    Browse the repository at this point in the history

  5. use horizontal arrows with emoji picker menu

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    37525aa View commit details
    Browse the repository at this point in the history

  6. remove unused condition

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b143573 View commit details
    Browse the repository at this point in the history

  7. cleanup emoji picker menu

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    222ba38 View commit details
    Browse the repository at this point in the history

  8. more cleanup for horizontal arrows

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e6e324b View commit details
    Browse the repository at this point in the history

  9. reduce diff between mobile and web

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d053504 View commit details
    Browse the repository at this point in the history

  10. fix cyclic traversal focus

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4e2d916 View commit details
    Browse the repository at this point in the history

  11. update naming to focusedIndex

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    613bc28 View commit details
    Browse the repository at this point in the history

  12. reduce diff

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e8d35df View commit details
    Browse the repository at this point in the history

  13. code review updates

    @TMisiukiewicz
    TMisiukiewicz committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    773787f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. add newlines for better readability

    @TMisiukiewicz
    TMisiukiewicz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    61287bc View commit details
    Browse the repository at this point in the history

  2. memoize disabled indexes

    @TMisiukiewicz
    TMisiukiewicz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    54197c0 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary condition

    @TMisiukiewicz
    TMisiukiewicz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e916dab View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/implement-horizontal-arrows

    @TMisiukiewicz
    TMisiukiewicz committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    46dadfd View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. fix selecting first emoji from filtered list

    @TMisiukiewicz
    TMisiukiewicz committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7ebc0f4 View commit details
    Browse the repository at this point in the history

  2. fix linting

    @TMisiukiewicz
    TMisiukiewicz committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7d61634 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. fix linting

    @TMisiukiewicz
    TMisiukiewicz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d6789ed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/implement-horizontal-arrows

    @TMisiukiewicz
    TMisiukiewicz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2dba4c6 View commit details
    Browse the repository at this point in the history