-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'WorkspaceTravel' page to TypeScript #34752
Merged
neil-marcellini
merged 12 commits into
Expensify:main
from
callstack-internal:pac-guerreiro/refactor/migrate-workspacetravelpage-to-typescript
Feb 13, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
713b968
refactor(typescript): migrate workspacetravelpage
pac-guerreiro 3c4d961
refactor(typescript): apply pull request feedback
pac-guerreiro 987f727
Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacetrav…
pac-guerreiro f8f6354
chore(typescript): resolve typing issues
pac-guerreiro a1864f6
chore(typescript): resolve typing issues
pac-guerreiro 5d2a5d6
Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacetrav…
pac-guerreiro cacbde3
Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacetrav…
pac-guerreiro 6eae40b
Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacetrav…
pac-guerreiro 04f348e
fix(typescript): typing issues
pac-guerreiro 9a9c00c
refactor: revert change
pac-guerreiro aea86e3
Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacetrav…
pac-guerreiro a41d909
refactor: apply pull request feedback
pac-guerreiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from 'react'; | ||
import {View} from 'react-native'; | ||
import ConnectBankAccountButton from '@components/ConnectBankAccountButton'; | ||
import * as Illustrations from '@components/Icon/Illustrations'; | ||
import Section from '@components/Section'; | ||
import Text from '@components/Text'; | ||
import useLocalize from '@hooks/useLocalize'; | ||
import useThemeStyles from '@hooks/useThemeStyles'; | ||
|
||
type WorkspaceTravelNoVBAViewProps = { | ||
/** The policy ID currently being configured */ | ||
policyID: string; | ||
pac-guerreiro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}; | ||
|
||
function WorkspaceTravelNoVBAView({policyID}: WorkspaceTravelNoVBAViewProps) { | ||
const styles = useThemeStyles(); | ||
const {translate} = useLocalize(); | ||
|
||
return ( | ||
<Section | ||
title={translate('workspace.travel.unlockConciergeBookingTravel')} | ||
icon={Illustrations.Luggage} | ||
isCentralPane | ||
> | ||
<View style={styles.mv3}> | ||
<Text>{translate('workspace.travel.noVBACopy')}</Text> | ||
</View> | ||
<ConnectBankAccountButton | ||
policyID={policyID} | ||
style={styles.mt4} | ||
/> | ||
</Section> | ||
); | ||
} | ||
|
||
WorkspaceTravelNoVBAView.displayName = 'WorkspaceTravelNoVBAView'; | ||
|
||
export default WorkspaceTravelNoVBAView; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubabutkiewicz Because it's inherited from
WithPolicyAndFullscreenLoadingProps