Fix: Delay in updating green dot and total amount #34866

tienifr · 2024-01-22T04:07:31Z

Details

Fixed Issues

$ #33774
PROPOSAL: #33774 (comment)

Tests

Log in as User B
Go to 1:1 DM with User A > Click IOU preview
Request the same amount from User A to make the net owe become 0
Note the the green dot for the main chat in LHN
Return to main chat
Return to the IOU report
Delete the requested amount created in Step 3
Verify that in Step 3, once the net owe becomes 0, the green dot for the main chat in LHN will disappear
In Step 7, the new amount should update instantly, the green dot for the main chat in LHN will appear

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Log in as User B
Go to 1:1 DM with User A > Click IOU preview
Request the same amount from User A to make the net owe become 0
Note the the green dot for the main chat in LHN
Return to main chat
Return to the IOU report
Delete the requested amount created in Step 3
Verify that in Step 3, once the net owe becomes 0, the green dot for the main chat in LHN will disappear
In Step 7, the new amount should update instantly, the green dot for the main chat in LHN will appear

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-01-22.at.11.15.59.mov

iOS: Native

Screen.Recording.2024-01-22.at.10.59.30.mp4

iOS: mWeb Safari

Screen.Recording.2024-01-22.at.10.55.43.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-01-22.at.10.36.01.mov

MacOS: Desktop

Screen.Recording.2024-01-22.at.10.58.21.mp4

melvin-bot · 2024-01-22T04:07:58Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-01-22T04:59:10Z

@thienlnam it looks like Melvin assigned wrong C+. Could you help to assign @shubham1206agra and unassign me? Thanks

shubham1206agra · 2024-01-22T06:51:09Z

src/libs/actions/IOU.js

@@ -2646,6 +2654,13 @@ function deleteMoneyRequest(transactionID, reportAction, isSingleTransactionView
                  },
              ]
            : []),
+        {


For K2 to pick up

Sorry not for you. Its for me.

tienifr · 2024-01-25T07:49:13Z

@shubham1206agra any updates?

tienifr · 2024-01-31T10:29:14Z

@shubham1206agra Pls help review my PR when you have a chance. Thanks

shubham1206agra · 2024-01-31T16:43:37Z

Sorry for the delay. Will review this today.

shubham1206agra · 2024-02-05T05:48:51Z

@tienifr Can you check this case too?

Log in as User B
Go to 1:1 DM with User A > Click IOU preview
Request the same amount from User A to make the net owe become 0
Note the the green dot for the main chat in LHN
Return to main chat
Return to the IOU report
Edit the requested amount created in Step 3 to a lower amount.
Verify that in Step 3, once the net owe becomes 0, the green dot for the main chat in LHN will disappear
In Step 7, the new amount should update instantly, the green dot for the main chat in LHN will appear

This case seems to be not working as expected.

tienifr · 2024-02-05T10:50:08Z

@shubham1206agra This bug happens when users update amount. So I just updated the PR to handle this case.

Screen.Recording.2024-02-05.at.17.37.58.mp4

shubham1206agra · 2024-02-07T11:10:49Z

@tienifr Still not working (also delete). Can you pleae check again?

shubham1206agra · 2024-02-12T06:21:56Z

@tienifr Bump on the above.

tienifr · 2024-02-15T04:23:15Z

There were some changes that caused my PR to not work. policy?.isHarvestingEnabled -> policy?.harvesting?.enabled

I just resolved the conflicts and test well

tienifr · 2024-02-15T04:25:16Z

@shubham1206agra Here's the evidence

Screen.Recording.2024-02-15.at.11.19.15.mp4

shubham1206agra · 2024-02-15T05:42:20Z

@tienifr The green dot is not updating whenever you use other currency than your default currency.
Can you please check this?

tienifr · 2024-02-15T07:50:05Z

@shubham1206agra I think we can't. When using the different currency, we need to use data from BE to know the request is lower than other. Is that your mean?

tienifr · 2024-02-20T04:31:28Z

@shubham1206agra any updates?

tienifr · 2024-02-23T09:09:53Z

@shubham1206agra wdyt^?

shubham1206agra · 2024-02-23T09:18:56Z

Just resolve the conflicts and I will do the review today.

tienifr · 2024-02-24T11:03:15Z

@shubham1206agra Can you help review this PR soon? We're fixing in IOU.ts so it's prone to get conflicts

shubham1206agra · 2024-02-25T14:12:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

Screen.Recording.2024-02-25.at.7.33.05.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-25.at.7.37.09.PM.mov

mountiny

code looks good to me

mountiny · 2024-02-25T22:15:01Z

@tienifr can you merge main

tienifr · 2024-02-26T03:36:37Z

@mountiny I just merged main. We're good to go

tienifr · 2024-02-27T10:30:36Z

@mountiny Everything's good. We can merge this PR

tienifr · 2024-02-28T03:34:15Z

@mountiny Can you help process this PR soon to void some kind of conflicts? Thanks

mountiny

Thanks

OSBotify · 2024-02-28T21:05:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-29T00:06:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T23:31:08Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

akinwale · 2024-04-17T06:53:30Z

This PR caused a regression: #38425.

fix: Delay in updating green dot and total amount

1d21ded

tienifr changed the title ~~fix: Delay in updating green dot and total amount~~ Fix: Delay in updating green dot and total amount Jan 22, 2024

tienifr marked this pull request as ready for review January 22, 2024 04:07

tienifr requested a review from a team as a code owner January 22, 2024 04:07

melvin-bot bot requested review from hoangzinh and removed request for a team January 22, 2024 04:07

shubham1206agra reviewed Jan 22, 2024

View reviewed changes

thienlnam requested review from shubham1206agra and removed request for hoangzinh January 22, 2024 08:12

tienifr added 2 commits January 29, 2024 10:48

fix conflict

075cc6e

change params order

5c5b0ab

tienifr added 2 commits February 5, 2024 14:52

Merge branch 'main' into fix/33774

aa09bc7

fix update amount

3f10fe4

resolve conflicts

9037e45

tienifr added 2 commits February 15, 2024 14:55

lint fix

fe54650

fix conflicts

e5ebf0d

tienifr added 2 commits February 23, 2024 18:09

resolve conflicts

d630b01

fix conflicts

b076033

shubham1206agra approved these changes Feb 25, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny February 25, 2024 14:13

mountiny assigned tienifr Feb 25, 2024

mountiny previously approved these changes Feb 25, 2024

View reviewed changes

Merge branch 'main' into fix/33774

8beafa6

resolve conflicts

fa16620

tienifr dismissed mountiny’s stale review via fa16620 February 28, 2024 03:33

mountiny approved these changes Feb 28, 2024

View reviewed changes

mountiny merged commit 7c68b1d into Expensify:main Feb 28, 2024
16 checks passed

github-actions bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

melvin-bot bot mentioned this pull request Feb 29, 2024

[HOLD for payment 2024-03-07] [LOW] [P2P] [$500] IOU - Delay in updating green dot and total amount when the net amounts cancel each other out for 2 users #33774

Closed

6 tasks

This was referenced Mar 15, 2024

Web - Workspace - IOU moves in the LHN every time the merchant is changed #38425

Closed

Fix conditional statement for hasOutstandingChildRequest when calculating the optimistic data for IOU requests #38431

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Delay in updating green dot and total amount #34866

Fix: Delay in updating green dot and total amount #34866

tienifr commented Jan 22, 2024 •

edited

Loading

melvin-bot bot commented Jan 22, 2024

hoangzinh commented Jan 22, 2024

shubham1206agra Jan 22, 2024

tienifr Jan 22, 2024

shubham1206agra Jan 22, 2024

tienifr commented Jan 25, 2024

tienifr commented Jan 31, 2024

shubham1206agra commented Jan 31, 2024

shubham1206agra commented Feb 5, 2024

tienifr commented Feb 5, 2024

shubham1206agra commented Feb 7, 2024 •

edited

Loading

shubham1206agra commented Feb 12, 2024

tienifr commented Feb 15, 2024

tienifr commented Feb 15, 2024

shubham1206agra commented Feb 15, 2024

tienifr commented Feb 15, 2024

tienifr commented Feb 20, 2024

tienifr commented Feb 23, 2024

shubham1206agra commented Feb 23, 2024

tienifr commented Feb 24, 2024

shubham1206agra commented Feb 25, 2024

mountiny left a comment

mountiny commented Feb 25, 2024

tienifr commented Feb 26, 2024

tienifr commented Feb 27, 2024

tienifr commented Feb 28, 2024

mountiny left a comment

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

akinwale commented Apr 17, 2024

Fix: Delay in updating green dot and total amount #34866

Fix: Delay in updating green dot and total amount #34866

Conversation

tienifr commented Jan 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 22, 2024

hoangzinh commented Jan 22, 2024

shubham1206agra Jan 22, 2024

Choose a reason for hiding this comment

tienifr Jan 22, 2024

Choose a reason for hiding this comment

shubham1206agra Jan 22, 2024

Choose a reason for hiding this comment

tienifr commented Jan 25, 2024

tienifr commented Jan 31, 2024

shubham1206agra commented Jan 31, 2024

shubham1206agra commented Feb 5, 2024

tienifr commented Feb 5, 2024

shubham1206agra commented Feb 7, 2024 • edited Loading

shubham1206agra commented Feb 12, 2024

tienifr commented Feb 15, 2024

tienifr commented Feb 15, 2024

shubham1206agra commented Feb 15, 2024

tienifr commented Feb 15, 2024

tienifr commented Feb 20, 2024

tienifr commented Feb 23, 2024

shubham1206agra commented Feb 23, 2024

tienifr commented Feb 24, 2024

shubham1206agra commented Feb 25, 2024

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Feb 25, 2024

tienifr commented Feb 26, 2024

tienifr commented Feb 27, 2024

tienifr commented Feb 28, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 28, 2024

OSBotify commented Feb 29, 2024

OSBotify commented Feb 29, 2024

akinwale commented Apr 17, 2024

tienifr commented Jan 22, 2024 •

edited

Loading

shubham1206agra commented Feb 7, 2024 •

edited

Loading