-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: Search - "Invite a friend" banner do not move up when input field is focused in search page #35363
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Update: Uploading the recording in some time |
recheck |
Please upload screenshots/videos for Native as well. Please upload the screenshots/videos for Web and Desktop as well just by visiting/checking the pages that might be affected by this change to ensure there are no unforeseen regressions. As a principle, one needs to upload all screenshots/videos for all platforms unless one makes changes only to a platform specific file like |
Done, added for iOS native, Web and desktop :) |
Reviewer Checklist
Screenshots/VideosAndroid: NativebannerAndroid.mp4Android: mWeb ChromebannerAndroidChrome.mp4iOS: NativebanneriOS.mp4iOS: mWeb SafaribanneriOSSafari.mp4MacOS: Chrome / SafaribannerChrome.mp4MacOS: DesktopbannerDesktop.mp4 |
Feel free to ask on #expensify-open-source slack channel if you have issues with building Android |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CLA signing check is failing. Please comment the declaration again. It might work. @Amarparab2024 |
I have read the CLA Document and I hereby sign the CLA |
recheck |
thanks for the approval @c3024 :) It is failing to retrigger the check :) |
It appears you initially signed with your alt account. You might need to make a fresh PR closing this PR. @Amarparab2024 Let us see what @stitesExpensify says. |
bump @stitesExpensify for review :) |
This PR was raised before the Ideal Nav PR, do i need to pull in those changes? I presume that's the reason for the failing checks, @stitesExpensify ,
|
Yes, we will need to pull those changes in |
all tests are successful now :) @stitesExpensify , thanks for your patience |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.38-0 🚀
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.38-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀
|
Details
Fixed Issues
$ #35182
PROPOSAL: #35182 (comment)
Tests
Same as QA step
Offline tests
Same as QA step
QA Steps
Note: This is only possible for native devices, cannot reproduce on safari laptop or MacOS application as this issue is related to keyboard pop up.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
iOS: mWeb Safari
299822052-d51c2a91-b562-4af4-b484-7f7a2f0a455b.mp4
Android: mWeb Chrome
iOS: Native
Android: Native
MacOS: Desktop
Screencast.from.01-31-2024.05.15.47.PM.webm
MacOS: Chrome / Safari