Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with Distance - By adding 2nd add stop user can delete empty location #35829

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix bug with Distance - By adding 2nd add stop user can delete empty location #35829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
111c1a2
Fix bug with Distance - By adding 2nd add stop user can delete empty …
ZhenjaHorbach Feb 5, 2024
9070dc4
Update comment for shouldShowThreeDotsButton
ZhenjaHorbach Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/iou/request/step/IOURequestStepWaypoint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ function IOURequestStepWaypoint({

const locationBias = useLocationBias(allWaypoints, userLocation);
const waypointAddress = lodashGet(currentWaypoint, 'address', '');
// Hide the menu when there is only start and finish waypoint
const shouldShowThreeDotsButton = waypointCount > 2;
// Hide the menu when there is only start and finish waypoint or the current waypoint is empty
const shouldShowThreeDotsButton = waypointCount > 2 && waypointAddress;
const shouldDisableEditor =
isFocused &&
(Number.isNaN(parsedWaypointIndex) || parsedWaypointIndex < 0 || parsedWaypointIndex > waypointCount || (filledWaypointCount < 2 && parsedWaypointIndex >= waypointCount));
Expand Down
Loading