Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA][TS migration] Migrate config.local from e2e to Typescript #35902

Merged
merged 3 commits into from
Feb 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ Ideally you want to run these tests on your branch before you want to merge your

The tests can be run with the following CLI options:

- `--config`: Extend/Overwrite the default config with your values, e.g. `--config config.local.js`
- `--config`: Extend/Overwrite the default config with your values, e.g. `--config config.local.ts`
- `--includes`: Expects a string/regexp to filter the tests to run, e.g. `--includes "login|signup"`
- `--skipInstallDeps`: Skips the `npm install` step, useful during development
- `--development`: Applies some default configurations:
- Sets the config to `config.local.js`, which executes the tests with fewer iterations
- Sets the config to `config.local.ts`, which executes the tests with fewer iterations
- Runs the tests only on the current branch
- `--buildMode`: There are three build modes, the default is `full`:
1. **full**: rebuilds the full native app in (e2e) release mode
Expand Down
7 changes: 5 additions & 2 deletions tests/e2e/config.local.js → tests/e2e/config.local.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
module.exports = {
type Config = Record<string, string | number>;

const config: Config = {
MAIN_APP_PACKAGE: 'com.expensify.chat.e2e',
DELTA_APP_PACKAGE: 'com.expensify.chat.e2edelta',
MAIN_APP_PATH: './android/app/build/outputs/apk/e2e/release/app-e2e-release.apk',
DELTA_APP_PATH: './android/app/build/outputs/apk/e2edelta/release/app-e2edelta-release.apk',

BOOT_COOL_DOWN: 1 * 1000,
RUNS: 8,
};

export default config;
2 changes: 1 addition & 1 deletion tests/e2e/testRunner.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ let buildMode = 'full';
// When we are in dev mode we want to apply certain default params and configs
const isDevMode = args.includes('--development');
if (isDevMode) {
setConfigPath('config.local.js');
setConfigPath('config.local.ts');
buildMode = 'js-only';
}

Expand Down
Loading