-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New architecture] Upgrade react-native-picker-select
#36117
[New architecture] Upgrade react-native-picker-select
#36117
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-09.at.5.24.55.PM.movAndroid: mWeb ChromeScreen.Recording.2024-02-09.at.4.59.43.PM.moviOS: NativeScreen.Recording.2024-02-09.at.5.13.12.PM.moviOS: mWeb SafariScreen.Recording.2024-02-09.at.4.53.53.PM.movMacOS: Chrome / SafariScreen.Recording.2024-02-09.at.4.48.50.PM.movMacOS: DesktopScreen.Recording.2024-02-09.at.5.02.17.PM.mov |
We did not find an internal engineer to review this PR, trying to assign a random engineer to #35997 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀
|
Details
This PR includes a version upgrade of
react-native-picker-select
:git+https://github.com/Expensify/react-native-picker-select.git#7a407cd4174d9838a944c1c2e1cb4a9737ac69c5
git+https://github.com/Expensify/react-native-picker-select.git#da50d2c5c54e268499047f9cc98b8df4196c1ddf
More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293531588409
Fixed Issues
$ #35997
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-08.at.17.03.27.mov
Android: mWeb Chrome
Screen.Recording.2024-02-08.at.17.05.03.mov
iOS: Native
Screen.Recording.2024-02-08.at.16.40.26.mov
iOS: mWeb Safari
Screen.Recording.2024-02-08.at.16.53.10.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-08.at.16.59.54.mov
MacOS: Desktop
Screen.Recording.2024-02-08.at.16.58.12.mov