-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New architecture] Upgrade react-native-camera-roll
#36154
[New architecture] Upgrade react-native-camera-roll
#36154
Conversation
react-native-image-picker
react-native-image-picker
react-native-camera-roll
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@BartoszGrajdek, please resolve the conflicts. |
@roryabraham, does this need a C+ for testing? |
@thesahindia done! 😄 |
Thanks for asking @thesahindia, I'd say yes, it does, but we will pay $250 instead of the standard $500 since it's just a dependency ugprade |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeScreen.Recording.2024-02-17.at.12.08.14.AM.moviOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #35986 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Ready for your review @roryabraham |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Oh I didn't realise there was a patch file for thanks @mkhutornyi |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.43-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
Details
Fixed Issues
$ #35986
Tests
This library is only used on iOS for file download so let's check it only there.
In case it doesn't work for you make sure you gave permissions to Photos for Expensify App
Offline tests
N/A
QA Steps
This library is only used on iOS for file download so let's check it only there.
In case it doesn't work for you make sure you gave permissions to Photos for Expensify App
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
iOS: Native
ios.mov