-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS Migration] Migrate 'RoomNameInput' to TypeScript #36676
[TS Migration] Migrate 'RoomNameInput' to TypeScript #36676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you also fix the TS check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-26.at.21.47.36.android.movAndroid: mWeb ChromeScreen.Recording.2024-02-26.at.21.45.03.android.chrome.moviOS: NativeScreen.Recording.2024-02-26.at.21.48.52.ios.moviOS: mWeb SafariScreen.Recording.2024-02-26.at.21.50.29.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2024-02-26.at.21.35.12.web.movMacOS: DesktopScreen.Recording.2024-02-26.at.21.37.44.desktop.mov |
@mateuuszzzzz I found a bug, when we edit the root name, it doesn't auto-focus at the end of the room name. Screen.Recording.2024-02-23.at.17.42.31.mov |
@hoangzinh It should be fixed now. |
@mateuuszzzzz the TS check is failed |
@hoangzinh I fixed ts error |
@mateuuszzzzz could you solve the conflict again on this PR? Thanks |
@hoangzinh It should be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25090 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 1.4.45-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀
|
Details
Fixed Issues
$ #25090
PROPOSAL:
Tests
All test steps described in this PR should be followed to test this one as well:
#32432
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android.native.webm
Android: mWeb Chrome
Android.mWeb.webm
iOS: Native
iOS.native.mp4
iOS: mWeb Safari
iOS.mWeb.mp4
MacOS: Chrome / Safari
Browser.mov
MacOS: Desktop
Desktop.mov