-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error - "Please enter at least two different addresses" message remains #37231
Fix error - "Please enter at least two different addresses" message remains #37231
Conversation
@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
@hayata-suenaga, @DylanDylann I hope you check this PR again and let me know. |
@funny2code Please update all videos |
The changes look good. Testing now |
Reviewer Checklist
Screenshots/VideosAndroid: Native1a.movAndroid: mWeb Chrome1c.moviOS: Native1i.moviOS: mWeb Safari1s.movMacOS: Chrome / Safari1w.movMacOS: Desktop1d.mov |
@funny2code In your test step It is incorrect, let's update it to
|
🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #37263. |
@hayata-suenaga All yours |
It seems Melvin Bot is confused here |
@DylanDylann Thanks for your reviewing. I am recording again now. I will update the videos soon. |
@hayata-suenaga assigning you to review since you're assigned to the issue - #35437 Note: @funny2code - looks like you have unsigned commits, so we won't be able to merge |
@funny2code You need to revert old commit and sign commit again |
@DylanDylann I've updated all videos right now. Please check them out. |
@DylanDylann I will try to revert old ones |
ba5f5e3
to
d7fa6c5
Compare
Signed-off-by: Dejan <dejanbuk.dev@gmail.com>
d7fa6c5
to
8fd88e2
Compare
@DylanDylann @hayata-suenaga @Beamanator I fixed the the issue in the old commit. Please check it out again and let me know. Thanks. |
@hayata-suenaga Did you check the current PR out? I hope you update me as soon as possible. Thanks. |
@DylanDylann @hayata-suenaga Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@funny2code good work on your first PR!
I'm sorry that you had difficulties while making the PR, but it will become easier once you do two or three PRs!
I'm looking forward to see your proposals in other issues, too!
@hayata-suenaga Thank you |
@DylanDylann @hayata-suenaga When would you update me on Upwork? |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@OSBotify, @hayata-suenaga, @DylanDylann I checked the Upwork job link again just now. But for the issue #35437, it seems someone is already hired on Upwork. I am confused a bit. Please let me know how it works... |
I think it's @DylanDylann. @DylanDylann is also a contributor who reviews other contributors' PRs. Please wait for one week or more for the payment. If you have any questions on payments, please post them in the original issue. there is a person assigned here to handle payments |
@hayata-suenaga Thank you. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.45-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀
|
Details
Fixed Issues
$#35437
PROPOSAL:#35437 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://www.loom.com/share/e641199858d348ba80cee72cbc35deae?sid=64bda7f1-f92e-469e-8849-0ce7bbbf8bc4
Android: mWeb Chrome
https://www.loom.com/share/6cc73c9a558a4b9581f45aed172920c1?sid=ef24a693-cf77-4f32-b4aa-d0d8a900421d
iOS: Native
https://www.loom.com/share/4e845be6a97d421b8424beecefdd6a9e?sid=37294315-469a-4f7b-9eb6-8267e9e99ace
iOS: mWeb Safari
https://www.loom.com/share/67b0f372d64742849f8b407b9ede4d79?sid=c0f03ef3-bb9b-427b-971a-355a69a814f2
MacOS: Chrome / Safari
https://www.loom.com/share/fd83615af6dc475598368e810c9756d6?sid=219ec662-21f9-44a7-a1de-db176a3edd1e
MacOS: Desktop
https://www.loom.com/share/95b8f89a6f3546b29e986772522b077a?sid=c5a3c431-5273-40c9-8b3d-fcc610cca5c8