Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Categories] Add support for long category names #37389

Merged
merged 15 commits into from
Feb 28, 2024
Merged

[Categories] Add support for long category names #37389

merged 15 commits into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. Add prop isRowMultilineSupported to BaseSelectionList

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    630a17e View commit details
    Browse the repository at this point in the history

  2. Add isMultilineSupported prop to ListItem

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b7ab573 View commit details
    Browse the repository at this point in the history

  3. Add numberOfLines prop type to TextWithTooltip

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    52a2fed View commit details
    Browse the repository at this point in the history

  4. Pass isRowMultilineSupported in CategoryPicker

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f585826 View commit details
    Browse the repository at this point in the history

  5. Pass isMultilineSupported to ListItem

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3a87b37 View commit details
    Browse the repository at this point in the history

  6. Pass custom numberOfLines to TextWithTooltip

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b72a521 View commit details
    Browse the repository at this point in the history

  7. Add the missing prop comments in TextWithTooltip Props

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c140118 View commit details
    Browse the repository at this point in the history

  8. Run prettier

    @neonbhai
    neonbhai committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    261ae17 View commit details
    Browse the repository at this point in the history

  9. Add default prop value to numberOfLines 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @neonbhai @fedirjh
    neonbhai and fedirjh authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3f4172c View commit details
    Browse the repository at this point in the history

  10. Add default prop value to numberOfLines (web) 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @neonbhai @fedirjh
    neonbhai and fedirjh authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1c7c850 View commit details
    Browse the repository at this point in the history

  11. Remove null coalescing operator in favor of default value 

    Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
    @neonbhai @fedirjh
    neonbhai and fedirjh authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6d50cb5 View commit details
    Browse the repository at this point in the history

  12. Update src/components/SelectionList/types.ts 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @neonbhai @puneetlath
    neonbhai and puneetlath authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4576f78 View commit details
    Browse the repository at this point in the history

  13. Update src/components/SelectionList/types.ts 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @neonbhai @puneetlath
    neonbhai and puneetlath authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d928ea0 View commit details
    Browse the repository at this point in the history

  14. Update src/components/SelectionList/types.ts 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @neonbhai @puneetlath
    neonbhai and puneetlath authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0253712 View commit details
    Browse the repository at this point in the history

  15. Update src/components/TextWithTooltip/types.ts 

    Co-authored-by: Puneet Lath <puneet@expensify.com>
    @neonbhai @puneetlath
    neonbhai and puneetlath authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a3334e7 View commit details
    Browse the repository at this point in the history