-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging]Fix: App crashes when upload PDF #37484
Conversation
@getusha Please review this crash deploy blocker ASAP! Thanks! |
Will review it, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-29.at.9.15.07.PM.movAndroid: mWeb ChromeScreen.Recording.2024-02-29.at.9.19.07.PM.moviOS: NativeScreen.Recording.2024-02-29.at.9.04.31.PM.moviOS: mWeb SafariScreen.Recording.2024-02-29.at.9.16.42.PM.movMacOS: Chrome / SafariScreen.Recording.2024-02-29.at.9.13.12.PM.movMacOS: DesktopScreen.Recording.2024-02-29.at.9.22.51.PM.mov |
CachedPDFPaths.add(transaction.transactionID || reportActionID, path); | ||
const id = (transaction && transaction.transactionID) || reportActionID; | ||
if (path && id) { | ||
CachedPDFPaths.add(id, path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienifr just noticed this, since we should not be storing the path on web could we only add it on native?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CachePDFPath already has platform-dependent files (i.e. noop functions on web).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CachePDFPath already has platform-dependent files (i.e. noop functions on web).
Forgot about that 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[CP Staging]Fix: App crashes when upload PDF (cherry picked from commit e4e98a2)
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.45-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀
|
Details
This PR fixes app crashes when upload PDF due to undefined value.
Fixed Issues
$ #32232
$ #37469
PROPOSAL:
Tests
Offline tests
NA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-29.at.18.28.14-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-02-29.at.18.24.22-compressed.mov
iOS: Native
Screen.Recording.2024-02-29.at.18.08.25-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-02-29.at.18.11.41-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-02-29.at.18.09.42-compressed.mov
MacOS: Desktop
Screen.Recording.2024-02-29.at.18.09.42-compressed.mov