[Fix] mWeb - Chat - Device keyboard does not auto appear when editing a message

[BartoszGrajdek]

Details

Fixed Issues

$ #39263

Tests

1. Send a message
2. Try editing the message
3. Make sure that the keyboard appears on mWeb

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: mWeb Chrome

android.mov

iOS: mWeb Safari

ios.mov

[melvin-bot]

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[BartoszGrajdek]

cc @shubham1206agra @c3024 @thienlnam

[jayeshmangwani]

Reviewing... 🚀

[jayeshmangwani]

@BartoszGrajdek Not sure why but I am testing the change on my side and its not working for me, I have pulled your branch and merge latest main , installed node_modules, but yet i am facing the same issue in mWeb safari

issue-keyboard.mov

[BartoszGrajdek]

Hmm that's weird - and how does this work for you on android? 🤔 @jayeshmangwani

[jayeshmangwani]

Yes Android works fine for me

[jayeshmangwani]

Android-keyboard.mov

@BartoszGrajdek Android mWeb works fine, keyboard opens on edit

[BartoszGrajdek]

I'll check why it's not working on iOS in that case, give me a moment 👀

[BartoszGrajdek]

And does the keyboard open in the main composer when you open a chat on iOS?

[BartoszGrajdek]

@thienlnam could we create an adhoc just for web here? I'd like to run it on a real device

[thienlnam]

Kicked off the adhoc build

[jayeshmangwani]

Screen.Recording.2024-03-30.at.2.45.03.AM.mov

@BartoszGrajdek yes initially keyboard open, but when I press the edit then keyboard does not open

[BartoszGrajdek]

Sometimes these bugs related to keyboard are caused by simulators, so that's why I want to check if this may be the reason

[jayeshmangwani]

Note: I have tested the production version of the mWEB in real iOS device, and keyboard does not open in it too. please check, on edit if keyboard opens on the real device on your side or not.

@BartoszGrajdek @thienlnam

[BartoszGrajdek]

Only after I click once again directly into the edit composer does the keyboard open - tested on mWeb prod using real device (iOS)

[BartoszGrajdek]

If that's the case I wouldn't even consider this bug we're trying to fix a blocker @thienlnam

[jayeshmangwani]

For me, iOS mweb Production and Staging works same way,
But For Android mWeb, in Production the keyboard will be appeared when edit , but in staging keyboard is not appeared on edit ,
So I think we here in this PR, trying to fix the Android mWeb inconsistency between staging and prod,
What's next for this PR @thienlnam @BartoszGrajdek ?

[thienlnam]

Since it already partially functions like that on production, we don't have to handle this with immediate urgency anymore. However, let's continue as planned in this PR making sure that this solves the issue where editing a message opens the keyboard on both mWeb for Android and iOS

[thienlnam]

Also, it looks like the adhoc build failed - not sure why but I'll try to re-run it

EDIT: Ah, I forgot the label

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39286/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39286/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39286/NewExpensify.dmg	https://39286.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[BartoszGrajdek]

After testing with adhoc it's not working on a real device as well - I'm not sure why it's fixed only on my simulator 🤯

[jayeshmangwani]

There is an old issue that is related to safari mWeb input #10414, and it has more context, so should we proceed with a fix on the Android mWeb on this PR, or should we wait? @thienlnam @BartoszGrajdek

[thienlnam]

Let's wait for the other issue - since this isn't fixed with these current changes