Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoQA] Update CODEOWNERS to support Design team handle for src/styles/ directory #39365

Merged
merged 4 commits into from
Apr 2, 2024
Merged

[NoQA] Update CODEOWNERS to support Design team handle for src/styles/ directory #39365

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e691276
Update CODEOWNERS to support design team
shawnborton Apr 1, 2024
c4d2fd5
Include pullerbear as well
shawnborton Apr 1, 2024
fb82744
Capital D designers
shawnborton Apr 1, 2024
103431a
Back to little d, add assets folder
shawnborton Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
# Every PR gets a review from an internal Expensify engineer
* @Expensify/pullerbear

# Assign the Design team to review changes to our styles & assets
src/styles/ @Expensify/design @Expensify/pullerbear
assets/ @Expensify/design @Expensify/pullerbear
Comment on lines +5 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's necessary to add pullerbear here too since it's already an owner on * but haven't tested, so maybe it's necessary to make sure design doesn't override. NAB since it doesn't seem like a problem 🤷

Loading