fix Reddot pinned chat appears for approver after failed scanned #39970

dukenv0307 · 2024-04-09T21:11:51Z

Details

Fixed Issues

$ #37044
PROPOSAL: #37044 (comment)

Tests

Test case 1 (to make sure RBR on the LHN is only shown for the user that made the request):

Create a collect policy in OD as account A
Invite user B as employee
Log in as user B in NewDot
Create a expense report with a invalid receipt to fail the scanning
Log in to user A in NewDot
No RBR pinned chat appear in the LHN for the error message
Log in to user B in NewDot
Verify there is RBR pinned chat appearing in the LHN for the error message

Test case 2 (to make sure the RBRs on the report preview, money request preview, and the ones in the money request view are shown to every user that has access to them):

Create a collect policy in OD as account A
Invite user B as employee
Log in as user B in NewDot
Create a expense report with a invalid receipt to fail the scanning
Log in to user A in NewDot
Verify the RBRs on the report preview, money request preview, and the ones in the money request view are shown
Log in to user B in NewDot
Verify the RBRs on the report preview, money request preview, and the ones in the money request view are shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test case 1 (to make sure RBR on the LHN is only shown for the user that made the request):

Create a collect policy in OD as account A
Invite user B as employee
Log in as user B in NewDot
Create a expense report with a invalid receipt to fail the scanning
Log in to user A in NewDot
No RBR pinned chat appear in the LHN for the error message
Log in to user B in NewDot
Verify there is RBR pinned chat appearing in the LHN for the error message

Test case 2 (to make sure the RBRs on the report preview, money request preview, and the ones in the money request view are shown to every user that has access to them):

Create a collect policy in OD as account A
Invite user B as employee
Log in as user B in NewDot
Create a expense report with a invalid receipt to fail the scanning
Log in to user A in NewDot
Verify the RBRs on the report preview, money request preview, and the ones in the money request view are shown
Log in to user B in NewDot
Verify the RBRs on the report preview, money request preview, and the ones in the money request view are shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-10.at.04.24.13.mov

Android: mWeb Chrome

Screen.Recording.2024-04-10.at.04.26.47.mov

iOS: Native

Screen.Recording.2024-04-10.at.04.23.43.mov

iOS: mWeb Safari

Screen.Recording.2024-04-10.at.04.21.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-10.at.04.12.16.mov

MacOS: Desktop

Screen.Recording.2024-04-10.at.04.17.21.mov

…anned

melvin-bot · 2024-04-09T21:27:25Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-04-12T02:43:28Z

@eVoloshchak Please help review PR once you have a chance

dukenv0307 · 2024-04-16T07:27:26Z

@eVoloshchak In case you miss it

src/libs/ReportUtils.ts

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

dukenv0307 · 2024-04-23T10:22:37Z

@eVoloshchak Any updates here?

dukenv0307 · 2024-04-26T11:13:34Z

@eVoloshchak I resolved your comment. Pls help review the PR

dukenv0307 · 2024-04-30T10:33:41Z

@eVoloshchak Any update here?

eVoloshchak · 2024-04-30T13:17:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

24-05-06-15-31-55.mp4

Android: mWeb Chrome

Screen.Recording.2024-05-06.at.15.22.25.mov

iOS: Native

Screen.Recording.2024-05-06.at.15.14.34.mov

iOS: mWeb Safari

Screen.Recording.2024-05-06.at.15.17.10.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-06.at.15.11.55.mov

MacOS: Desktop

Screen.Recording.2024-05-06.at.15.17.50.mov

src/libs/ReportUtils.ts

eVoloshchak · 2024-04-30T14:11:49Z

@dukenv0307, looking good!
Could you also expand the testing steps a bit, please?
Overexplain so the QA team could test this properly, also there should be 2 test cases included (i.e. make sure RBR on the LHN is only shown for the user that made the request, while the RBRs on the report preview, money request preview, and the ones in the money request view are shown to every user that has access to them.

dukenv0307 · 2024-05-03T11:14:14Z

@eVoloshchak I updated the test steps

eVoloshchak

LGTM!

cead22 · 2024-05-06T21:40:39Z

@dukenv0307 do we need to do anything with the warning in your native android video?

cead22

This is probably a long shot, but are there automated tests we could add for this?

cead22 · 2024-05-06T21:44:25Z

src/libs/ReportUtils.ts

+ * NOTE: On LHN preview we show RBR only to the user that made the request.
+ * https://github.com/Expensify/App/issues/37044#issuecomment-1984922236
+ */
+function hasMissingSmartscanFields(iouReportID: string, isLHNPreview?: boolean): boolean {


This isn't where we landed

I agree with this, we shouldn't change hasMissingSmartscanFields, instead we could create shouldShowRBRForMissingSmartscanFields method, which would in turn call hasMissingSmartscanFields conditionally

Let's change this

I created shouldShowRBRForMissingSmartscanFields method

eVoloshchak · 2024-05-10T15:05:51Z

@dukenv0307, friendly bump on comments above

dukenv0307 · 2024-05-16T02:12:03Z

@eVoloshchak @cead22 Do you have any feedback about my comment here?

eVoloshchak · 2024-05-19T17:08:34Z

src/libs/ReportUtils.ts

-        const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingSmartscanFields(IOUReportID) && !isSettled(IOUReportID);
+        const isReportPreviewError =
+            ReportActionsUtils.isReportPreviewAction(action) &&
+            (isLHNPreview ? shouldShowRBRForMissingSmartscanFields(IOUReportID) : hasMissingSmartscanFields(IOUReportID)) &&


This is a bit hard to read, let's move this into a separate variable, something like

const hasMissingFields = isLHNPreview ? shouldShowRBRForMissingSmartscanFields(IOUReportID) : hasMissingSmartscanFields(IOUReportID); const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingFields && !isSettled(IOUReportID);

@eVoloshchak I updated and merged main as well.

cead22

How come we didn't implement isRequestor like in the proposal?
Can you update both test cases to sign in as User B and confirm things look right for that user?

src/libs/ReportUtils.ts

cead22 · 2024-05-21T22:10:31Z

src/libs/OptionsListUtils.ts

            reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxError('report.genericSmartscanFailureMessage');
        }
-    } else if (ReportUtils.hasSmartscanError(Object.values(reportActions ?? {}))) {
+    } else if (ReportUtils.hasSmartscanError(Object.values(reportActions ?? {}), true)) {


Are we calling ReportUtils.hasSmartscanError from anywhere else? Do we need the second param?

Even if we need it, I don't think it should be a separate param, and instead we should have that check outside of the ReportUtils.hasSmartscanError function, since that function name sounds like it shouldn't care about isLHNPreview

Are we calling ReportUtils.hasSmartscanError from anywhere else?

No

Do we need the second param?

I think we still need to create a isLHNPreview param then handle both case (isLHNPreview is true or false) in hasSmartscanError to reduce the duplicate logics.

As you can see, if we do like this, we just need to create a new variable, hasMissingField and apply a minor change to isReportPreviewError, the rest logic does not change.

I think we still need to create a isLHNPreview param then handle both case (isLHNPreview is true or false) in hasSmartscanError to reduce the duplicate logics.

I think I'm not following or I'm missing something, because if we always pass this as true, this doesn't make sense

That makes sense. I removed isLHNPreview in commit

src/libs/ReportUtils.ts

dukenv0307 · 2024-05-24T11:43:20Z

I am working on it

cead22 · 2024-05-27T15:57:06Z

src/libs/ReportActionsUtils.ts

+/**
+ * Check if the current user is the requestor of the action
+ */
+function isRequestor(reportAction: OnyxEntry<ReportAction>): boolean {


Sorry I kinda missed this in the proposal and original review, but I was thinking about reports when thinking about isRequestor, but for report actions, this name isn't great.

How about we call this something like ReportActionUtils.actionWasTakenByCurrentUser(reportAction)

I renamed it in commit

Cool, let me know when this is ready for re-review. Thanks

OSBotify · 2024-06-03T17:59:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:33:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits April 10, 2024 04:07

fix Reddot pinned chat appears for approver for submitter's failed sc…

69263a4

…anned

fix lint

fe5f752

dukenv0307 marked this pull request as ready for review April 9, 2024 21:27

dukenv0307 requested a review from a team as a code owner April 9, 2024 21:27

melvin-bot bot requested review from eVoloshchak and removed request for a team April 9, 2024 21:27

dukenv0307 mentioned this pull request Apr 9, 2024

[HOLD for payment 2024-06-13] [$500] Reddot pinned chat appears for approver for submitter's failed scanned receipt #37044

Closed

6 tasks

eVoloshchak suggested changes Apr 16, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

dukenv0307 and others added 5 commits April 17, 2024 02:13

fix update hasMissingSmartscanFields

1303c69

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

fix update hasSmartscanError

f082a5a

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

fix merge main

ec854c5

fix type

48ad489

fix type

590547f

dukenv0307 and others added 2 commits April 26, 2024 18:08

fix add comment

1be1d08

Merge branch 'main' into fix/37044

de0ae91

eVoloshchak suggested changes Apr 30, 2024

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

fix update comment

4d03c16

eVoloshchak approved these changes May 6, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 May 6, 2024 13:35

cead22 requested changes May 6, 2024

View reviewed changes

dukenv0307 added 2 commits May 10, 2024 23:48

fix create shouldShowRBRForMissingSmartscanFields

4560da2

fix lint

3fbf0f7

eVoloshchak reviewed May 19, 2024

View reviewed changes

dukenv0307 added 2 commits May 21, 2024 18:38

fix create hasMissingFields variable

8866eb7

fix merge main

83500fc

eVoloshchak approved these changes May 21, 2024

View reviewed changes

melvin-bot bot requested a review from cead22 May 21, 2024 13:44

cead22 requested changes May 21, 2024

View reviewed changes

dukenv0307 added 3 commits May 27, 2024 08:44

fix suggestion logics

97ce514

fix create isRequestor

4c35a47

fix merge main

0c68919

cead22 requested changes May 27, 2024

View reviewed changes

dukenv0307 and others added 3 commits May 31, 2024 23:05

Merge branch 'main' into fix/37044

6e342bc

fix remove isLHNPreview and create actionWasTakenByCurrentUser

4ef770d

fix typecheck

728ae68

cead22 approved these changes Jun 3, 2024

View reviewed changes

cead22 merged commit 908d29c into Expensify:main Jun 3, 2024
15 checks passed

This was referenced Jun 3, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #43009

Closed

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix Reddot pinned chat appears for approver after failed scanned #39970

fix Reddot pinned chat appears for approver after failed scanned #39970

dukenv0307 commented Apr 9, 2024 •

edited

Loading

melvin-bot bot commented Apr 9, 2024

dukenv0307 commented Apr 12, 2024

dukenv0307 commented Apr 16, 2024

dukenv0307 commented Apr 23, 2024

dukenv0307 commented Apr 26, 2024

dukenv0307 commented Apr 30, 2024

eVoloshchak commented Apr 30, 2024 •

edited

Loading

eVoloshchak commented Apr 30, 2024

dukenv0307 commented May 3, 2024

eVoloshchak left a comment

cead22 commented May 6, 2024

cead22 left a comment

cead22 May 6, 2024

dukenv0307 May 10, 2024

eVoloshchak commented May 10, 2024

dukenv0307 commented May 16, 2024

eVoloshchak May 19, 2024

dukenv0307 May 21, 2024

cead22 left a comment

cead22 May 21, 2024

dukenv0307 May 27, 2024 •

edited

Loading

cead22 May 27, 2024

dukenv0307 May 31, 2024

dukenv0307 commented May 24, 2024

cead22 May 27, 2024

dukenv0307 May 31, 2024

cead22 May 31, 2024

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

fix Reddot pinned chat appears for approver after failed scanned #39970

fix Reddot pinned chat appears for approver after failed scanned #39970

Conversation

dukenv0307 commented Apr 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Test case 1 (to make sure RBR on the LHN is only shown for the user that made the request):

Test case 2 (to make sure the RBRs on the report preview, money request preview, and the ones in the money request view are shown to every user that has access to them):

Offline tests

QA Steps

Test case 1 (to make sure RBR on the LHN is only shown for the user that made the request):

Test case 2 (to make sure the RBRs on the report preview, money request preview, and the ones in the money request view are shown to every user that has access to them):

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 9, 2024

dukenv0307 commented Apr 12, 2024

dukenv0307 commented Apr 16, 2024

dukenv0307 commented Apr 23, 2024

dukenv0307 commented Apr 26, 2024

dukenv0307 commented Apr 30, 2024

eVoloshchak commented Apr 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak commented Apr 30, 2024

dukenv0307 commented May 3, 2024

eVoloshchak left a comment

Choose a reason for hiding this comment

cead22 commented May 6, 2024

cead22 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eVoloshchak commented May 10, 2024

dukenv0307 commented May 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cead22 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 May 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dukenv0307 commented May 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

dukenv0307 commented Apr 9, 2024 •

edited

Loading

eVoloshchak commented Apr 30, 2024 •

edited

Loading

dukenv0307 May 27, 2024 •

edited

Loading